New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626606 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Buildbot Android Tests (dbg) failing test PaymentRequestFreeShippingTest#testChangeCountryAddAddressAndPay

Project Member Reported by gsennton@chromium.org, Jul 8 2016

Issue description

Link to bot
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg)


I  857.732s Main  FINISHED TRY #3/3
I  857.732s Main  1 failed tests remain.
C  857.738s Main  ********************************************************************************
C  857.738s Main  Detailed Logs
C  857.738s Main  ********************************************************************************
C  857.741s Main  [FAIL] org.chromium.chrome.browser.payments.PaymentRequestFreeShippingTest#testChangeCountryAddAddressAndPay:
C  857.741s Main  java.lang.AssertionError
C  857.741s Main  	at org.chromium.chrome.browser.payments.ui.EditorView.addFieldViewToEditor(EditorView.java:293)
C  857.741s Main  	at org.chromium.chrome.browser.payments.ui.EditorView.prepareEditor(EditorView.java:243)
C  857.741s Main  	at org.chromium.chrome.browser.payments.ui.EditorView.access$400(EditorView.java:51)
C  857.741s Main  	at org.chromium.chrome.browser.payments.ui.EditorView$5.run(EditorView.java:278)
C  857.741s Main  	at android.os.Handler.handleCallback(Handler.java:733)
C  857.741s Main  	at android.os.Handler.dispatchMessage(Handler.java:95)
C  857.741s Main  	at android.os.Looper.loop(Looper.java:136)
C  857.741s Main  	at android.app.ActivityThread.main(ActivityThread.java:5001)
C  857.741s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  857.741s Main  	at java.lang.reflect.Method.invoke(Method.java:515)
C  857.741s Main  	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
C  857.741s Main  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
C  857.741s Main  	at dalvik.system.NativeStart.main(Native Method)



I think this is caused by 
https://codereview.chromium.org/2114493002
I'll see if I can repro locally with that CL and if so I'll just revert it.
 
Yeah, so the crash in the following assert:

if (fieldModel.getInputTypeHint() == EditorFieldModel.INPUT_TYPE_HINT_PHONE) {
    assert mPhoneInput == null;
    mPhoneInput = input;
}

I ran this locally with the CL in https://codereview.chromium.org/2114493002 and mPhoneInput is indeed non-null so this assert fails on a debug run. Going ahead and reverting patch.
The revert for ToT is https://codereview.chromium.org/2137443002/ which has now landed. However, the original change was cherry-picked to 53 as well, so I should probably revert that as well :/
Labels: -Restrict-View-Google
Status: Fixed (was: Assigned)
Revert for 53 landed as well, see
https://codereview.chromium.org/2133113002/

I reopened  crbug.com/626451 

Sign in to add a comment