New issue
Advanced search Search tips

Issue 626605 link

Starred by 2 users
Status: WontFix
Owner:
rogerm@chromium.org
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0.3% regression in sizes at 404157:404161

Project Member Reported by alexclarke@chromium.org, Jul 8 2016 
See the link to graphs below.

Comment 1 by alexclarke@chromium.org, Jul 8 2016 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=626605

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg0rHWpgoM


Bot(s) for this bug's original alert(s):

Google Chrome Linux x64

Comment 2 by sullivan@chromium.org, Jul 15 2016

Owner: rogerm@chromium.org
rogerm, looking at the build-per-revision chart, it's pretty clear this is your cl "Embed address normalization rewriting rules." (https://codereview.chromium.org/2121253002).
https://chromeperf.appspot.com/report?sid=cce459dcee89765c7fe679257ecb26cc7c282fac97f3417549a2846c620b8865&start_rev=404086&end_rev=405835

Can we WontFix since it was reverted? Or did it reland?

Comment 3 by rogerm@chromium.org, Jul 15 2016 

It relanded.

Thus CL embeds additional static string data about how to rewrite addresses
in various geos.

Comment 4 by rogerm@chromium.org, Jul 15 2016 

The relanded cl is https://codereview.chromium.org/2137533002

Comment 5 by sullivan@chromium.org, Jul 15 2016

Status: WontFix (was: Assigned)
Thanks! Looks like the reland didn't affect the binary size as much; WontFix-ing this.
►

Sign in to add a comment