MediaStreamVideoTrack::getSettings will sometimes return the wrong settings. |
||||
Issue description<b>Version: <Kenneth, what is the frequency?></b> <b>OS: <please tell me it's not XP></b> What steps will reproduce the problem? (1). call gUM with resolution 1280 720 - This will create track1 with this reso. (2) call gUM wiht res 640* 360 using the same source. This will create track2 with res 640 * 360. Note that the source of this track is the same as track1. (3) Call track2.GetSettings. This will return 1280*720. (The settings for the source settings, not the track settings) What is the expected output? As I understand the spec, track2.GetSettings should return the settigns the track actually output, not the resolution the camera is currenlty producing. (Noticed when looking at https://bugs.chromium.org/p/chromium/issues/detail?id=605250)
,
Jul 11 2016
[triage]
,
Jan 17 2017
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/977056bc7c6be8e98eb98f9702b3f4ed3eb992dd commit 977056bc7c6be8e98eb98f9702b3f4ed3eb992dd Author: hta <hta@chromium.org> Date: Wed Mar 15 13:05:35 2017 Let getSettings() return the constrained track resolution, not source. This lets MediaStreamTrack.getSettings() on a track that has been limited in size due to constraints return the constrained size rather than the original size. Test note: Due to limits of the mock devices, tests don't work with content_shell. They have been verified to work in a browser, and upstreamed to web-platform-tests. https://github.com/w3c/web-platform-tests/pull/5114 BUG= 626595 Review-Url: https://codereview.chromium.org/2742893003 Cr-Commit-Position: refs/heads/master@{#457064} [modify] https://crrev.com/977056bc7c6be8e98eb98f9702b3f4ed3eb992dd/content/renderer/media/media_stream_video_source.cc [modify] https://crrev.com/977056bc7c6be8e98eb98f9702b3f4ed3eb992dd/content/renderer/media/media_stream_video_track.cc [modify] https://crrev.com/977056bc7c6be8e98eb98f9702b3f4ed3eb992dd/content/renderer/media/media_stream_video_track.h [modify] https://crrev.com/977056bc7c6be8e98eb98f9702b3f4ed3eb992dd/content/renderer/media/video_track_adapter.cc [modify] https://crrev.com/977056bc7c6be8e98eb98f9702b3f4ed3eb992dd/content/renderer/media/video_track_adapter.h [modify] https://crrev.com/977056bc7c6be8e98eb98f9702b3f4ed3eb992dd/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings.html
,
Mar 15 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by perkj@chromium.org
, Jul 8 2016oh, version - M53 -- refs/heads/master@{#402751}