New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626575 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Turn flag opt-in-ime-menu off.

Project Member Reported by azurewei@chromium.org, Jul 8 2016

Issue description

The command flag "opt-in-ime-menu" for the feature Bug: 570761, should be turned off by default, as the launch has been moved to M54.

 
The cl for turning off the flag:

https://codereview.chromium.org/2123363003/

Comment 2 by dimu@google.com, Jul 9 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 12 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86f1ba44758d861b53bfc2030fec876878e7e69d

commit 86f1ba44758d861b53bfc2030fec876878e7e69d
Author: azurewei <azurewei@chromium.org>
Date: Wed Jul 13 01:48:42 2016

Revert of Turn flag opt-in-ime-menu on by default. (patchset #2 id:20001 of https://codereview.chromium.org/2068953002/ )

Reason for revert:
This feature will not be launched in M53.

Original issue's description:
> Turn flag: opt-in-ime-menu on by default, which aims to launch on M53.
>
> BUG=570761
> TEST=Verified on local build.
>
> Committed: https://crrev.com/8a07498f562fc6bab382e01b5e711421fa30ef72
> Cr-Commit-Position: refs/heads/master@{#400374}

TBR=thestig@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=570761,  626575 

Review-Url: https://codereview.chromium.org/2123363003
Cr-Commit-Position: refs/heads/master@{#404062}
(cherry picked from commit ef7941838399b1b0f9b7d6c2fa08337f943bb4e4)

Review-Url: https://codereview.chromium.org/2139403003
Cr-Commit-Position: refs/branch-heads/2785@{#100}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/86f1ba44758d861b53bfc2030fec876878e7e69d/chrome/common/chrome_features.cc

Labels: -Hotlist-Merge-Approved
Status: Fixed (was: Assigned)
All merges have been completed. 
Remove the remaining Merge-Approved labels from this issue.
Labels: VerifyIn-54
Status: Verified (was: Fixed)
 opt-in-ime-menu on by default and can see the input option on Shelf on M54

Sign in to add a comment