Regression: Animation effect is not seen on hovering in some sections of http://ianlunn.github.io/Hover/ |
|||||||||||||
Issue descriptionVersion: 54.0.2791.0 dev OS: Ubuntu 14.04,windows What steps will reproduce the problem? (1) Launch chrome and go to http://ianlunn.github.io/Hover/ >> Now hover on Bounce to right/top/left/bottom etc in Background transistions or hover on Icon back/forward options in Icon section and observe. Expected: Animation effect should be seen on hovering on any element in all sections. Actual: Instead no animation effect is seen on hovering. This is a regression issue broken in M53. Will provide bisect info in a while
,
Jul 8 2016
Good Build: 53.0.2783.0 dev Bad Build: 53.0.2784.0 dev CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/78d1ddce57dd1da3a9d166ebbfae758d32307185..849f8df4aa51c333cd14286b51673acc90e9b862 Suspecting https://codereview.chromium.org/1973083002 from changelog. @vollick: Please help in re-assigning if it is not related to your change.
,
Jul 11 2016
Still able to repro this issue on Chrome Canary Version - 54.0.2793.0
,
Jul 11 2016
Issue 625712 has been merged into this issue.
,
Jul 11 2016
It appears that the problem is that I'm constructing the "element id" using different nodes causing mismatches which prevent the starting of the animation. The CompositedLayerMapping seems to have incorrectly been using generatingNode which returns a different element for pseudo's than the one that gets plumbed to CompositorAnimations. I have a fix uploaded here, https://codereview.chromium.org/2141743002
,
Jul 11 2016
Seems to also affect animation on pseudo ::after elements, hoping the patch will fix this as well. Repro: http://jsbin.com/bokipev/edit?html,output
,
Jul 12 2016
Vollick@ can you please request for merge of CL in Comment#6(https://codereview.chromium.org/2141743002 ) to M53 2785 branch please.
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10b3fec07dfda5c362f1fc27a314468541c72ae0 commit 10b3fec07dfda5c362f1fc27a314468541c72ae0 Author: vollick <vollick@chromium.org> Date: Wed Jul 13 02:40:41 2016 Use node() when generating element id's The current code followed the lead of crrev.com/279553002 and incorrectly used generatingNode, which lead to discrepancies when animating pseudo elements. It seems that node() is the correct choice, both here and in the CL I referenced. BUG= 626571 Review-Url: https://codereview.chromium.org/2141743002 Cr-Commit-Position: refs/heads/master@{#404921} [add] https://crrev.com/10b3fec07dfda5c362f1fc27a314468541c72ae0/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation-expected.html [add] https://crrev.com/10b3fec07dfda5c362f1fc27a314468541c72ae0/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html [modify] https://crrev.com/10b3fec07dfda5c362f1fc27a314468541c72ae0/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/10b3fec07dfda5c362f1fc27a314468541c72ae0/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
,
Jul 13 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10b3fec07dfda5c362f1fc27a314468541c72ae0 commit 10b3fec07dfda5c362f1fc27a314468541c72ae0 Author: vollick <vollick@chromium.org> Date: Wed Jul 13 02:40:41 2016 Use node() when generating element id's The current code followed the lead of crrev.com/279553002 and incorrectly used generatingNode, which lead to discrepancies when animating pseudo elements. It seems that node() is the correct choice, both here and in the CL I referenced. BUG= 626571 Review-Url: https://codereview.chromium.org/2141743002 Cr-Commit-Position: refs/heads/master@{#404921} [add] https://crrev.com/10b3fec07dfda5c362f1fc27a314468541c72ae0/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation-expected.html [add] https://crrev.com/10b3fec07dfda5c362f1fc27a314468541c72ae0/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html [modify] https://crrev.com/10b3fec07dfda5c362f1fc27a314468541c72ae0/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/10b3fec07dfda5c362f1fc27a314468541c72ae0/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
,
Jul 14 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 14 2016
M53 beta launch is coming soon.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix before 6:00 PM PST, Monday (07/18/16). Thank you.
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b49a371fb95d08b33bd3d35ac87e41186ff19de commit 8b49a371fb95d08b33bd3d35ac87e41186ff19de Author: Ian Vollick <vollick@chromium.org> Date: Fri Jul 15 18:32:21 2016 Use node() when generating element id's The current code followed the lead of crrev.com/279553002 and incorrectly used generatingNode, which lead to discrepancies when animating pseudo elements. It seems that node() is the correct choice, both here and in the CL I referenced. BUG= 626571 Review-Url: https://codereview.chromium.org/2141743002 Cr-Commit-Position: refs/heads/master@{#404921} (cherry picked from commit 10b3fec07dfda5c362f1fc27a314468541c72ae0) Review URL: https://codereview.chromium.org/2150413002 . Cr-Commit-Position: refs/branch-heads/2785@{#160} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [add] https://crrev.com/8b49a371fb95d08b33bd3d35ac87e41186ff19de/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation-expected.html [add] https://crrev.com/8b49a371fb95d08b33bd3d35ac87e41186ff19de/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html [modify] https://crrev.com/8b49a371fb95d08b33bd3d35ac87e41186ff19de/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/8b49a371fb95d08b33bd3d35ac87e41186ff19de/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
,
Jul 15 2016
,
Jul 18 2016
Issue 626545 has been merged into this issue.
,
Jul 19 2016
Retested the above issue on All-OS(Windows, Mac 10.11.5 & Ubuntu 14.04) with chrome version '53.0.2785.21' & Animation effect are on hovering on any element in all sections. Attach is the screencast for the same. Thank you! |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by ajha@chromium.org
, Jul 8 2016Status: Untriaged (was: Unconfirmed)