New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626546 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Find next doesn't work in expected spatial order

Project Member Reported by dcheng@chromium.org, Jul 8 2016

Issue description

Chrome Version       : 53.0.2785.8
OS Version: 
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Install https://chrome.google.com/webstore/detail/rietveld-usability-toolki/nmljjlfbnbekmadhbpfpkcminoejelga
2. Load a code review like https://codereview.chromium.org/2096293002/
3. Click "Show All" to expand all the diffs inline.
4. Search for the string ".mojom" (no quotes)

What is the expected result?
Find next should jump inside the inline diff (in an iframe) if the iframe is 'logically' next.

What happens instead of that?
Find next cycles through all the hits in the main frame, then starts cycling through hits in the iframes.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.8 Safari/537.36


(Note that I'm finding this very convenient, but I don't recall if this was an intentional behavior change or not?)
 
Status: WontFix (was: Assigned)
This is the expected behavior, but it has not changed. This the same order of matches as in the old find-in-page implementation (before my work), and I intentionally reproduced the same order in the new implementation.

Frames are searched as a whole, so all matches in the same frame will always be contiguous in search order, and then the frames themselves have a specific order in which they are searched (also the same as before).

Sign in to add a comment