Autofill: Credit Card import fails when expiration date is not a specific format |
|||||||
Issue description2 digit years are not supported, as well as some combinations of mm/yyyy.
,
Jul 8 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/303f4384d13900b31a5b854843b2a18d36176639 commit 303f4384d13900b31a5b854843b2a18d36176639 Author: mathp <mathp@chromium.org> Date: Fri Jul 08 19:43:07 2016 [Autofill] Improve support for various credit card expiration dates. Supports 2-digit years, and various combinations of mm/yyyy and single digit month combinations (e.g. m/yy). BUG= 626537 TEST=CreditCardTest,PersonalDataManagerTest Review-Url: https://codereview.chromium.org/2136453003 Cr-Commit-Position: refs/heads/master@{#404467} [modify] https://crrev.com/303f4384d13900b31a5b854843b2a18d36176639/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/303f4384d13900b31a5b854843b2a18d36176639/components/autofill/core/browser/credit_card.h [modify] https://crrev.com/303f4384d13900b31a5b854843b2a18d36176639/components/autofill/core/browser/credit_card_unittest.cc [modify] https://crrev.com/303f4384d13900b31a5b854843b2a18d36176639/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/303f4384d13900b31a5b854843b2a18d36176639/components/autofill/core/browser/validation.cc [modify] https://crrev.com/303f4384d13900b31a5b854843b2a18d36176639/components/autofill/core/browser/validation.h [modify] https://crrev.com/303f4384d13900b31a5b854843b2a18d36176639/components/autofill/core/browser/validation_unittest.cc
,
Jul 8 2016
,
Jul 8 2016
Self-contained change, requesting merge to M-53
,
Jul 9 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/915707859844eade749a2f732f9f3382adcf2918 commit 915707859844eade749a2f732f9f3382adcf2918 Author: Mathieu Perreault <mathp@chromium.org> Date: Sat Jul 09 19:02:45 2016 [Merge M53] [Autofill] Improve support for various credit card expiration dates. Supports 2-digit years, and various combinations of mm/yyyy and single digit month combinations (e.g. m/yy). BUG= 626537 TEST=CreditCardTest,PersonalDataManagerTest Review-Url: https://codereview.chromium.org/2136453003 Cr-Commit-Position: refs/heads/master@{#404467} (cherry picked from commit 303f4384d13900b31a5b854843b2a18d36176639) Review URL: https://codereview.chromium.org/2139483002 . Cr-Commit-Position: refs/branch-heads/2785@{#66} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/credit_card.h [modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/credit_card_unittest.cc [modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/validation.cc [modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/validation.h [modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/validation_unittest.cc
,
Jul 12 2016
Tested this issue on Windows 7 using chrome latest Dev M53-53.0.2785.14 using the site Peapod.com, I am able to autofill the credit cards expiry year but not the month which is in mm/yy format. mathp@ - Could you please provide any other sample test case or URL of this issue where we can verify it from chrome TE end.
,
Jul 19 2016
@mathp: Gentle ping, can you please update us as requested in the above comment. Thanks.!
,
Jul 19 2016
We are not testing Autofill, we are testing card import. You should be offered to save a card after submitting on a site with these formats.
,
Jul 19 2016
There is no good webpage where we can test this since it has to be one where expiration is all in one field. 05/2020(based in offline chat with mathp@) |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ma...@chromium.org
, Jul 8 2016