New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626537 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Autofill: Credit Card import fails when expiration date is not a specific format

Project Member Reported by ma...@chromium.org, Jul 8 2016

Issue description

2 digit years are not supported, as well as some combinations of mm/yyyy.
 

Comment 1 by ma...@chromium.org, Jul 8 2016

Cc: jsaul@google.com jdonnelly@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 8 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 8 2016

Comment 4 by ma...@chromium.org, Jul 8 2016

Status: Fixed (was: Started)

Comment 5 by ma...@chromium.org, Jul 8 2016

Labels: -M-54 -MovedFrom-53 Merge-Request-53 M-53
Self-contained change, requesting merge to M-53

Comment 6 by dimu@google.com, Jul 9 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 9 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/915707859844eade749a2f732f9f3382adcf2918

commit 915707859844eade749a2f732f9f3382adcf2918
Author: Mathieu Perreault <mathp@chromium.org>
Date: Sat Jul 09 19:02:45 2016

[Merge M53] [Autofill] Improve support for various credit card expiration dates.

Supports 2-digit years, and various combinations of mm/yyyy and single digit month combinations (e.g. m/yy).

BUG= 626537 
TEST=CreditCardTest,PersonalDataManagerTest

Review-Url: https://codereview.chromium.org/2136453003
Cr-Commit-Position: refs/heads/master@{#404467}
(cherry picked from commit 303f4384d13900b31a5b854843b2a18d36176639)

Review URL: https://codereview.chromium.org/2139483002 .

Cr-Commit-Position: refs/branch-heads/2785@{#66}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/credit_card.h
[modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/validation.cc
[modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/validation.h
[modify] https://crrev.com/915707859844eade749a2f732f9f3382adcf2918/components/autofill/core/browser/validation_unittest.cc

Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Tested this issue on Windows 7 using chrome latest Dev M53-53.0.2785.14 using the site Peapod.com, I am able to autofill the credit cards expiry year but not the month which is in mm/yy format.

mathp@ - Could you please provide any other sample test case or URL of this issue where we can verify it from chrome TE end.

CreditCardDate.JPG
57.1 KB View Download
@mathp: Gentle ping, can you please update us as requested in the above comment.

Thanks.!

Comment 10 by ma...@chromium.org, Jul 19 2016

We are not testing Autofill, we are testing card import. You should be offered to save a card after submitting on a site with these formats.
There is no good webpage where we can test this since it has to be one where expiration is all in one field. 05/2020(based in offline chat with mathp@)

Sign in to add a comment