New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626532 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Update the Public Suffix List for M-53

Project Member Reported by rsleevi@chromium.org, Jul 8 2016

Issue description

See Issue 610495 for the full description.
 
M53 Stable launch is coming soon.Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix asap so it gets chance to bake in beta before stable promotion. Thank you.

Comment 2 by gov...@chromium.org, Aug 15 2016

M53 Stable launch is coming VERY soon.Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix asap so it gets chance to bake in beta before stable promotion later this month. Thank you.

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17 2016

Cc: pbomm...@chromium.org gov...@chromium.org rnimmagadda@chromium.org
Labels: Needs-Feedback
@rsleevi: Could you please let us know if there any manual steps for TE to verify this fix.

I really appreciate your help.

Thank you!
There is no additional updates required here since team will update the dataset 2 weeks before the release, As updated by  rsleevi@ on bug report crbug.com/610495 is the umbrella bug for TPM/PMO's.
Labels: -Needs-Feedback Merge-Request-53
Setting M-R now that it's baked 2 days (reminder: data only change)

Comment 7 by dimu@chromium.org, Aug 19 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 8 by gov...@chromium.org, Aug 19 2016

Please merge your change to M53 branch 2785 before 5:00 PM PT on Monday so we can take it in for next week LAST M53 beta release for Desktop. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 21 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f62a246505937ae10b65d861ced6ac872675828

commit 9f62a246505937ae10b65d861ced6ac872675828
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Sun Aug 21 19:13:00 2016

Refresh Public Suffic List to the latest version

This updates from revision
28e17a0f8f26f1bddfbd62d9861b223efa7792bc (2016-07-06)

to revision
4dcaacaf593dde7e2a34436913c24af3bf2bdb06 (2016-08-16)

R=pkasting@chromium.org
BUG= 626532 

Review-Url: https://codereview.chromium.org/2248253002
Cr-Commit-Position: refs/heads/master@{#412419}
(cherry picked from commit 702d65e434b5a41965f5b9fbe644e9e4300157b6)

Review URL: https://codereview.chromium.org/2266753002 .

Cr-Commit-Position: refs/branch-heads/2785@{#697}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/9f62a246505937ae10b65d861ced6ac872675828/net/base/registry_controlled_domains/effective_tld_names.dat

Realized when merging that I forgot to update the generated datafile, so that CL - https://codereview.chromium.org/2263923002/ - will also have to be Merge-Requested.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a16e791c295658f7253f30ab7680ce74b7e0b93b

commit a16e791c295658f7253f30ab7680ce74b7e0b93b
Author: rsleevi <rsleevi@chromium.org>
Date: Sun Aug 21 21:43:33 2016

Update the generated public suffix file

Commit 702d65e434b5a41965f5b9fbe644e9e4300157b6
updated the underlying data file, but the
generated .gperf file was not re-generated because
I forgot to run net/tools/tld_cleanup on it.

TBR'ing because it's a file derived from the
already reviewed CL.

TBR=pkasting@chromium.org
BUG= 626532 , 639677

Review-Url: https://codereview.chromium.org/2263923002
Cr-Commit-Position: refs/heads/master@{#413380}

[modify] https://crrev.com/a16e791c295658f7253f30ab7680ce74b7e0b93b/net/base/registry_controlled_domains/effective_tld_names.gperf

A friendly reminder that M53 Stable is launching VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP (before 5:00 PM PT, Tuesday) so we can take it for this week LAST Beta release for Desktop. Thank you!

Note: Merge has to happen by Friday, August 26th, 5:00 PM PST in order to make into the desktop Stable final build cut. 
Seems like CL listed at #c11 didn't make it to last night canary (#413380 vs Canary branch #413363)

Can we please wait until it is baked/verified in canary and safe to merge?





Cc: pkasting@chromium.org
Please merge this change to M53 branch 2785 ASAP if CL listed at #c11 is baked in canary (Note: If merge happens before 5:00 PM PT today, then we can take it in for tomorrow's beta release).
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ec0afd588845ef505a04d3d4123949220fb18b8

commit 9ec0afd588845ef505a04d3d4123949220fb18b8
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Thu Aug 25 18:00:56 2016

Update the generated public suffix file

Commit 702d65e434b5a41965f5b9fbe644e9e4300157b6
updated the underlying data file, but the
generated .gperf file was not re-generated because
I forgot to run net/tools/tld_cleanup on it.

TBR'ing because it's a file derived from the
already reviewed CL.

TBR=pkasting@chromium.org
BUG= 626532 , 639677

Review-Url: https://codereview.chromium.org/2263923002
Cr-Commit-Position: refs/heads/master@{#413380}
(cherry picked from commit a16e791c295658f7253f30ab7680ce74b7e0b93b)

Review URL: https://codereview.chromium.org/2270193005 .

Cr-Commit-Position: refs/branch-heads/2785@{#750}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/9ec0afd588845ef505a04d3d4123949220fb18b8/net/base/registry_controlled_domains/effective_tld_names.gperf

Status: Verified (was: Assigned)
Blocking: -610495

Sign in to add a comment