New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626523 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 621198
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

52.5% regression in media.tough_video_cases at 401711:401728

Project Member Reported by w...@chromium.org, Jul 8 2016

Issue description

See the link to graphs below.
 

Comment 1 by w...@chromium.org, Jul 8 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=626523

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwom3sQkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac10

Comment 2 by w...@chromium.org, Jul 8 2016

Cc: w...@chromium.org
Owner: sunn...@chromium.org
sunnyps@: looks like this change causes an regression in idle wakeups. https://chromium.googlesource.com/chromium/src/+/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29

Could you take a look please?
Mergedinto: 621198
Status: Duplicate (was: Assigned)
Thanks for the report. This is being tracked in  issue 621198 .
Cc: sunn...@chromium.org

=== Auto-CCing suspected CL author sunnyps@chromium.org ===

Hi sunnyps@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ )
Author  : sunnyps
Commit description:
  
Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG= 525259 
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

R=piman@chromium.org
BUG= 525259 ,  621422 , 621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2081883002
Cr-Commit-Position: refs/heads/master@{#401717}
Commit  : b3071e4aabd0cb1f29cd624e77eb5f40722be965
Date    : Thu Jun 23 21:23:50 2016


===== TESTED REVISIONS =====
Revision         Mean   Std Dev  N  Good?
chromium@401710  241.8  5.54076  5  good
chromium@401715  242.0  5.33854  5  good
chromium@401716  239.0  3.67423  5  good
chromium@401717  361.8  11.8828  5  bad    <--
chromium@401719  364.4  7.1624   5  bad
chromium@401728  363.0  10.5594  5  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 626523

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests media.tough_video_cases
Test Metric: idle_wakeups_gpu/idle_wakeups_gpu
Relative Change: 50.12%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2189
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007746918597485600


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5807772994633728

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment