New issue
Advanced search Search tips

Issue 626517 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 621198
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.2% regression in media.tough_video_cases at 402333:402349

Project Member Reported by w...@chromium.org, Jul 8 2016

Issue description

See the link to graphs below.
 

Comment 1 by w...@chromium.org, Jul 8 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=626517

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4vbW5wgM


Bot(s) for this bug's original alert(s):

chromium-rel-mac10
Cc: sunn...@chromium.org
Owner: sunn...@chromium.org

=== Auto-CCing suspected CL author sunnyps@chromium.org ===

Hi sunnyps@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #1 id:1 of https://codereview.chromium.org/2106503002/ )
Author  : sunnyps
Commit description:
  
Original issue's description:
> Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #5 id:70001 of https://codereview.chromium.org/2081883002/ )
>
> Reason for revert:
> Causing canvas crashes - bug 623101
>
> Original issue's description:
> > Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ )
> >
> > Original issue's description:
> > > cc: Add mailbox support to ResourceProvider write locks.
> > >
> > > This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> > > requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> > > ensures that the texture id for the mailbox is destroyed after use on
> > > the worker context.
> > >
> > > This CL also includes the following cleanup:
> > > 1. ResourceProvider locks don't keep resource pointers around.
> > > 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> > > 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> > > 4. TileTaskManager does not own RasterBufferProvider.
> > >
> > > BUG= 525259 
> > > R=piman@chromium.org
> > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> > >
> > > Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> > > Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> > > Cr-Original-Commit-Position: refs/heads/master@{#398204}
> > > Cr-Commit-Position: refs/heads/master@{#399983}
> >
> > R=piman@chromium.org
> > BUG= 525259 ,  621422 , 621130
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> >
> > Committed: https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965
> > Cr-Commit-Position: refs/heads/master@{#401717}
>
> TBR=piman@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 525259 ,  621422 , 621130
>
> Committed: https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194
> Cr-Commit-Position: refs/heads/master@{#402290}

TBR=piman@chromium.org
BUG= 525259 ,  621422 , 621130

Review-Url: https://codereview.chromium.org/2101043002
Cr-Commit-Position: refs/heads/master@{#402345}
Commit  : 5d6ff0d0e4c450cfb12aef3b455f63d380731935
Date    : Tue Jun 28 00:42:02 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@402332  1305.2  18.8468  5  good
chromium@402341  1296.4  21.8815  5  good
chromium@402343  1290.8  43.0546  5  good
chromium@402344  1287.0  37.45    5  good
chromium@402345  1425.2  20.2163  5  bad    <--
chromium@402349  1409.0  31.3688  5  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 626517

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests media.tough_video_cases
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 7.95%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2188
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007747341731653472


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5789085390602240

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 8 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 621198
Status: Duplicate (was: Assigned)

Sign in to add a comment