New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626511 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

findit Infra python unit test flake.

Project Member Reported by d...@chromium.org, Jul 8 2016

Issue description

I've hit this flake a few times today. P1 b/c it has wasted a bit of time trying to get things through CQ.

======================================================================
ERROR: handlers.crash.test.fracas_dashboard_test.FracasDashBoardTest.testFilterWithSuspectsUntriaged (/b/rr/tmpuTfHfJ/w/infra/appengine/findit/handlers/crash/test/fracas_dashboard_test.expected/FracasDashBoardTest.testFilterWithSuspectsUntriaged.json)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/rr/tmpuTfHfJ/w/infra/ENV/local/lib/python2.7/site-packages/expect_tests/pipeline.py", line 397, in process_test
    subresult = subtest.run()
  File "/b/rr/tmpuTfHfJ/w/infra/ENV/local/lib/python2.7/site-packages/expect_tests/type_definitions.py", line 240, in run
    return self.func_call(context=context)
  File "/b/rr/tmpuTfHfJ/w/infra/ENV/local/lib/python2.7/site-packages/expect_tests/type_definitions.py", line 155, in __call__
    return f.func(*f.args, **f.kwargs)
  File "/b/rr/tmpuTfHfJ/w/infra/ENV/local/lib/python2.7/site-packages/expect_tests/unittest_helper.py", line 31, in _RunTestCaseSingle
    return Result(getattr(test_instance, test_name)())
  File "/b/rr/tmpuTfHfJ/w/infra/appengine/findit/handlers/crash/test/fracas_dashboard_test.py", line 228, in testFilterWithSuspectsUntriaged
    self.assertEqual(expected_result, response_json.json_body)
  File "/usr/lib/python2.7/unittest/case.py", line 515, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 837, in assertDictEqual
    self.fail(self._formatMessage(msg, standardMsg))
  File "/usr/lib/python2.7/unittest/case.py", line 412, in fail
    raise self.failureException(msg)
AssertionError: {'fracas_crashes': [{'stack_trace': u'dummy\nframe1\nframe2', 'regression_range' [truncated]... != {u'fracas_crashes': [], u'end_date': u'2016-07-08 00:00:00 UTC', u'regression_ra [truncated]...
Diff is 1373 characters long. Set self.maxDiff to None to see it.
==== captured logging output ====


Example build: https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%2064%20Tester/builds/2985
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.infra%2FInfra_Linux_Trusty_64_Tester%2F2985%2F%2B%2Frecipes%2Fsteps%2Fpython_tests%2F0%2Fstdout
 

Comment 1 by st...@chromium.org, Jul 12 2016

Owner: kateso...@chromium.org
Status: Assigned (was: Untriaged)
Sharu, please disable the test first (with TBR) and then fix it asap.

Please also fix similar flake tests in  issue 624998 .
Components: -Infra Infra>Flakiness
This is related to timestamp, upload fix soon.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/b6b2c25f84c821e3c20feb509c9d366ea30905f2

commit b6b2c25f84c821e3c20feb509c9d366ea30905f2
Author: katesonia <katesonia@chromium.org>
Date: Wed Jul 13 00:11:07 2016

[Findit] Fix flaky dashboard test.

The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by hard-coding the request time of testcases and setting start_date and end_date in the request.

BUG= 624998 ,  626511 

Review-Url: https://codereview.chromium.org/2147773002

[modify] https://crrev.com/b6b2c25f84c821e3c20feb509c9d366ea30905f2/appengine/findit/handlers/crash/test/fracas_dashboard_test.py

Status: Fixed (was: Assigned)

Sign in to add a comment