New issue
Advanced search Search tips

Issue 626510 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 609258



Sign in to add a comment

Record WebAPK related metrics

Project Member Reported by pkotw...@chromium.org, Jul 8 2016

Issue description

Non-WebAPK web apps set the ShortcutHelper#EXTRA_SOURCE extra on the home screen launch intent. This is recorded to UMA in WebappLauncherActivity

We need to figure out how to record this data for WebAPKs. Setting a <meta-data> tag in the AndroidManifest with "what caused the WebAPK to be created" does not play nicely with the WebAPK server
 
We could probably just capture a different measure - number of webapks installed via banner or menu (not # of launches per installation source). Then separately we can also track launches
Blocking: 609258
Owner: hanxi@chromium.org
Status: Assigned (was: Untriaged)
Assigning this bug to Xi since she is already working on this (https://codereview.chromium.org/2301263004/)
Summary: Record WebAPK related metrics (was: Record metrics for how WebAPK shortcut was added)
We should also collect metrics for how often:
- we check whether the WebAPK should be updated
- request a WebAPK update

Dominick mentioned that those metrics would be useful in https://codereview.chromium.org/2331773002/
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07373421ccbda77a1a3882bd045fbf4ce1a707fa

commit 07373421ccbda77a1a3882bd045fbf4ce1a707fa
Author: hanxi <hanxi@chromium.org>
Date: Tue Sep 27 14:36:17 2016

Pass WebAPK install source to AppBannerInfobarDelegateAndroid constructor.

This is a follow up CL for CL (https://codereview.chromium.org/2301263004).
The InstallSource is passed into the constructor of
AppBannerInfoBarDelegationAndroid, so we can call Accept() instead of
AcceptWebApk() when installing a WebAPK from add-to-homescreen menu.

BUG= 626510 

Review-Url: https://codereview.chromium.org/2375503003
Cr-Commit-Position: refs/heads/master@{#421202}

[modify] https://crrev.com/07373421ccbda77a1a3882bd045fbf4ce1a707fa/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
[modify] https://crrev.com/07373421ccbda77a1a3882bd045fbf4ce1a707fa/chrome/browser/android/banners/app_banner_infobar_delegate_android.h
[modify] https://crrev.com/07373421ccbda77a1a3882bd045fbf4ce1a707fa/chrome/browser/android/banners/app_banner_manager_android.cc
[modify] https://crrev.com/07373421ccbda77a1a3882bd045fbf4ce1a707fa/chrome/browser/android/webapps/add_to_homescreen_manager.cc

Is this bug done?

Comment 9 by hanxi@chromium.org, Jan 24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment