'git cl try' only spawns closure_compilation tryjob |
|||
Issue descriptionAs of https://chromium.googlesource.com/chromium/src/+/2d0143560f25e9589140c4d9198a0e5e45d02c33, when executing 'git cl try' for a CL that only touches JS files, a single tryjob is spawned. It seems that the original intent was to add 'closure_compilation' to all tryjobs that were previously spawned, instead of replacing them.
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7efcec187700f4868968b0087ed6d68beaab30e7 commit 7efcec187700f4868968b0087ed6d68beaab30e7 Author: dbeam <dbeam@chromium.org> Date: Tue Jul 12 02:54:09 2016 Revert of Add closure_compilation to `git cl try` for CLs that touch resources (patchset #1 id:20001 of https://codereview.chromium.org/2129793002/ ) Reason for revert: Just use CQ dry run instead. See also, recent improvements: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/Ale4kvbwVS8/discussion Original issue's description: > Add closure_compilation to `git cl try` for CLs that touch resources > > R=dpapad@chromium.org > BUG=none > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > NOTRY=true > > Committed: https://crrev.com/2d0143560f25e9589140c4d9198a0e5e45d02c33 > Cr-Commit-Position: refs/heads/master@{#403978} R=dpapad@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 626503 NOTRY=true Review-Url: https://codereview.chromium.org/2142553004 Cr-Commit-Position: refs/heads/master@{#404770} [modify] https://crrev.com/7efcec187700f4868968b0087ed6d68beaab30e7/chrome/browser/resources/PRESUBMIT.py [modify] https://crrev.com/7efcec187700f4868968b0087ed6d68beaab30e7/ui/webui/resources/PRESUBMIT.py
,
Jul 12 2016
,
Jul 12 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dbeam@chromium.org
, Jul 11 2016Owner: dbeam@chromium.org
Status: Started (was: Untriaged)