New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626493 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Data race in blink::MediaQueryEvaluator::eval

Project Member Reported by ClusterFuzz, Jul 7 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5954650943782912

Fuzzer: attekett_surku_fuzzer
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race READ 8
Crash Address: 0x7f43e8c9a428
Crash State:
  blink::MediaQueryEvaluator::eval
  blink::MediaQueryEvaluator::eval
  blink::MediaQueryEvaluator::eval
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=403874:403894

Minimized Testcase (0.11 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96S6wuT0J7W5X8dE6UdKgjaWVRjorSTp_MbcEJg9hLK6KjBYy-3UNoYZdSTZF5D9-fiEosUlabHAdaoPNDtunBu7mmLimzx5LNTkqmjo1q7SpPJ68yLP2WyTH3CTiqH8sqLNhtfVDkHtLvIvozmFp6GRRGv7g?testcase_id=5954650943782912

Filer: mummareddy

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: y...@yoav.ws
Components: Tools>Test>FindIt>NoResult Blink>CSS
Labels: Te-Logged M-53
Owner: dgozman@chromium.org
Status: Assigned (was: Available)
Still seeing this crash. yoav@ please take a look.
Thank you
Cc: -y...@yoav.ws dgozman@chromium.org
Owner: y...@yoav.ws

Comment 3 by y...@yoav.ws, Jul 8 2016

Can you attach the test case here (or send it to me by mail)? I don't have access permissions to clusterfuzz
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 8 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please find the attached testcase. thank you.
fuzz-29.html
109 bytes View Download

Comment 6 by y...@yoav.ws, Jul 11 2016

Cc: kouhei@chromium.org
@kouhei - maybe https://codereview.chromium.org/2041013004/ is weirdly responsible for this? (It's the only CL in the range that seems vaguely related)

Comment 7 by kouhei@chromium.org, Jul 11 2016

Cc: y...@yoav.ws
Owner: kouhei@chromium.org
CL: https://codereview.chromium.org/2135083003/
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce6b9dfd435e967107e9677a902371864ef1bc59

commit ce6b9dfd435e967107e9677a902371864ef1bc59
Author: kouhei <kouhei@chromium.org>
Date: Mon Jul 11 21:43:45 2016

Initialize gFunctionMap from CoreInitializer

Before this CL, gFunctionMap init was racy, as it could be initialized from both BackgroundParserThread/CrRendererMain.
This CL ties the init to blink::initialize() to avoid the issue.

BUG= 626493 

Review-Url: https://codereview.chromium.org/2135083003
Cr-Commit-Position: refs/heads/master@{#404738}

[modify] https://crrev.com/ce6b9dfd435e967107e9677a902371864ef1bc59/third_party/WebKit/Source/core/CoreInitializer.cpp
[modify] https://crrev.com/ce6b9dfd435e967107e9677a902371864ef1bc59/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/ce6b9dfd435e967107e9677a902371864ef1bc59/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h

Comment 9 by kouhei@chromium.org, Jul 12 2016

Status: Fixed (was: Assigned)
Project Member

Comment 10 by ClusterFuzz, Jul 12 2016

ClusterFuzz has detected this issue as fixed in range 404631:404810.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5954650943782912

Fuzzer: attekett_surku_fuzzer
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race READ 8
Crash Address: 0x7f43e8c9a428
Crash State:
  blink::MediaQueryEvaluator::eval
  blink::MediaQueryEvaluator::eval
  blink::MediaQueryEvaluator::eval
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=403874:403894
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=404631:404810

Minimized Testcase (0.11 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96S6wuT0J7W5X8dE6UdKgjaWVRjorSTp_MbcEJg9hLK6KjBYy-3UNoYZdSTZF5D9-fiEosUlabHAdaoPNDtunBu7mmLimzx5LNTkqmjo1q7SpPJ68yLP2WyTH3CTiqH8sqLNhtfVDkHtLvIvozmFp6GRRGv7g?testcase_id=5954650943782912

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Components: -Tools>Test>FindIt>NoResult
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment