New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626492 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 618468



Sign in to add a comment

mac_chromium_gyp_rel doesn't have enough builders

Project Member Reported by kbr@chromium.org, Jul 7 2016

Issue description

mac_chromium_gyp_rel is running for all CQ jobs per src/infra/config/cq.cfg but there are only 5 VMs allocated for it in tools/build/masters/master.tryserver.chromium.mac/slaves.cfg . This doesn't appear to be enough and has caused tryserver timeouts per Issue 626473.

Depending on how long this tryserver will be used, would any of the following possibilities work?

 - Deploy new VMs per Issue 626473.
 - Change it to use the cq_slaves pool (but presumably a different build directory so that incremental builds continue to work with both GN and GYP)
 - Something else?

 
Cc: sergeybe...@chromium.org phajdan.jr@chromium.org
Owner: dpranke@chromium.org
Status: Assigned (was: Untriaged)
Ah, whoops.

When I set up the builder initially, I thought it would just be optional, but then we decided to keep the GYP build around and not ship GN in 53, so I put it into the CQ.

But, without the needed capacity, apparently. Which is a bit strange as I'm sure I checked things, but maybe during a slow week ...
This is blocking the CQ.
Status: Started (was: Assigned)
Sorry for not updating ... I have a fix in flight: https://codereview.chromium.org/2132853002/ .
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/806721f8af64e95a635c91d8a80c75afd458a348

commit 806721f8af64e95a635c91d8a80c75afd458a348
Author: dpranke <dpranke@chromium.org>
Date: Fri Jul 08 00:28:12 2016

Take mac, win gyp builders out of the CQ.

This CL takes mac_chromium_gyp_rel out of the CQ (by default),
dropping it down to a 10% experiment, just to keep the builder
working some of the time. The builder doesn't currently have
enough capacity to handle the full CQ load, and it's unclear
if we really want to keep any GYP builders on the waterfall.

This CL also drops the win8_chromium_gyp_rel builder from 50%
to 10%, also because it's unclear if we want to keep GYP builders
around.

TBR=kbr@chromium.org
NOTRY=true
BUG= 626492 

Review-Url: https://codereview.chromium.org/2132853002
Cr-Commit-Position: refs/heads/master@{#404274}

[modify] https://crrev.com/806721f8af64e95a635c91d8a80c75afd458a348/infra/config/cq.cfg

Status: Fixed (was: Started)
Closing this as I think we're probably good for now.
Status: Started (was: Fixed)
Hmm, apart from the fact that there are 90 pending builds still.

There also seem to be 105 pending builds on the mac_chromium_10.10_rel_ng builder, despite it having 19 machines in its pool.

Did something happen today on the mac builders to make everything take forever and/or retry?

I'm going to re-open this and bump the 10.10_rel_ng builder down to 50% and take the gyp_rel build out of the experimental altogether for now.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12b791371788f449ff3782d4707992f3a017a2f7

commit 12b791371788f449ff3782d4707992f3a017a2f7
Author: dpranke <dpranke@chromium.org>
Date: Fri Jul 08 14:14:38 2016

More Mac CQ builder adjusting.

This CL takes mac_chromium_gyp_rel out of the CQ altogether,
and drops mac_chromium_10.10_rel_ng to a 50% experiment to
help it get caught up.

TBR=kbr@chromium.org
NOTRY=true
BUG= 626492 

Review-Url: https://codereview.chromium.org/2131083002
Cr-Commit-Position: refs/heads/master@{#404361}

[modify] https://crrev.com/12b791371788f449ff3782d4707992f3a017a2f7/infra/config/cq.cfg

Status: Fixed (was: Started)
Things seem to be better, so I'm going to close this. the 10.10 builder still has pending builds, but also seems kinda borked. It's experimental, so I'll ignore it for now.

Sign in to add a comment