New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626491 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Infra PRR: Milo for public tryjobs

Project Member Reported by estaab@chromium.org, Jul 7 2016

Issue description

********
This template is for submitting a Chrome Infra app or service to the
Production Readiness Review process. See http://go/cit-prr for details.

Please place your answers to the questions below on new lines.
********

========
Name of application:
Milo

========
Name of cloud project:
luci-milo

========
Source location(s):
https://github.com/luci/luci-go/tree/master/appengine/cmd/milo

========
Url(s) at which app is/will be deployed:
luci-milo.appspot.com

========
Documentation location(s):
https://github.com/luci/luci-go/tree/master/appengine/cmd/milo

========
Viceroy dashboard:
https://viceroy.corp.google.com/chrome_infra/Appengine/luci_milo

========
Bug component/queue:
Infra>Platform>Milo

========
Bug triage rotation members:
estaab, hinoka, nodir (predicated on general triaging guidelines benhenry is working on)

========
GAR Web Self-Assessment doc:
https://docs.google.com/spreadsheets/d/1xoQ-SiEY7JkyfZlQKpt7_yyFSEyN_aVEq7PGMBSQXcU/edit#gid=0

========
Security Questionnaire:
N/A, just public tryjobs for now.

========

********
Thanks! A Chrome Infra PRReviewer will take ownership of this bug and
reach out to you shortly.
********

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/bb54a9ac375732ffabb277d480b90ceec58bba00

commit bb54a9ac375732ffabb277d480b90ceec58bba00
Author: estaab <estaab@google.com>
Date: Fri Jul 08 02:06:34 2016

Components: -Infra Infra>Platform>Milo

Comment 3 by aga...@chromium.org, Jul 18 2016

Cc: seanmccullough@chromium.org
Owner: aga...@chromium.org
Status: Started (was: Assigned)
✓ Go (preferably) or Python (legacy)
✓ Tests in CQ/CI
✓ Source in canonical location
✗ Design Doc
✗ Test coverage > 80%
✗ Polymer for frontend framework
✓ Billing set up correctly
✓ chrome-troopers is an Editor
✗ Uses gae.py for deployment
✗ Staging instance
✓ Entry in go/chrome-infra-services
□ Playbook entries
✗ Documented APIs
✓ Top-level README
✗ Links to help and documentation
✓ Incorporate ts_mon
✓ Have a viceroy dashboard
□ Alerts are "Level 3 Certified"
□ Entry on infra.chromium.org
✗ CIT Feedback button
□ Security review
□ Privacy review
✓ Monorail component
✓ Bug triage rotation

Questions / Comments:
* Design doc: I was only able to find https://docs.google.com/document/d/1xBrZsQvPneBB49jPfOIhWYqLtnWMyIX2HwdhSQYca3Q/edit?ts=566f0673. Is that the most up-to-date design doc? Is there a roadmap for additional features Milo plans to grow? How well does it stack up against that original doc?
* Test coverage: I don't see a coverage report on the luci-go bots, and I don't see a threshold configured in the source directory. Is this kept track of anywhere?
* Frontend: Obviously not using polymer right now, and that's fine, since it is so simple. Are there plans to improve on the "clone buildbot" look?
* Deployment: Do luci-go appengine apps have a unified deployment scheme? I don't see anything, either in terms of tooling or in the README. Similarly for staging -- I don't see a staging instance in my list of projects, or documented.
* APIs: I assume milo exposes a JSON api similar to regular buildbot. Is that true? Is it not? If so, is it documented anywhere?
* Links to docs and source: You already have a nice footer, it would be really easy to add these there.
* CIT Feedback button: I'd like to see one, and it should be easy :)


P.S. sorry for hijacking this, Sean, I didn't see it was assigned to you until I'd written this up. Feel free to steal back from me if you want to do the follow-up.
all you ;)
Labels: Type-Bug

Comment 6 by hinoka@chromium.org, Aug 30 2016

* Design doc: I was only able to find https://docs.google.com/document/d/1xBrZsQvPneBB49jPfOIhWYqLtnWMyIX2HwdhSQYca3Q/edit?ts=566f0673. Is that the most up-to-date design doc? Is there a roadmap for additional features Milo plans to grow? How well does it stack up against that original doc?
New doc! https://docs.google.com/document/d/16hGQIXqUzXAQ6cC1Dx9u4driFrbRbUHhQNOcYffj8LY/edit
Also slides: https://docs.google.com/presentation/d/1mzfjNmZtul8IHMhdPZOs5lKPwlloxqgBhj1DCp53O1o/edit

* Test coverage: I don't see a coverage report on the luci-go bots, and I don't see a threshold configured in the source directory. Is this kept track of anywhere?
It's kept track ad-hoc with goconvey, here's a screenshot.
https://screenshot.googleplex.com/ruUrVHnth8w

* Frontend: Obviously not using polymer right now, and that's fine, since it is so simple. Are there plans to improve on the "clone buildbot" look?
There are no plans to improve on the UI until after milo is fully rolled out and people have gotten used to it.  One variable at at time :)
Milo has themeing support however, so there will be a way to transition on a per-person basis.

* Deployment: Do luci-go appengine apps have a unified deployment scheme? I don't see anything, either in terms of tooling or in the README. Similarly for staging -- I don't see a staging instance in my list of projects, or documented.
There is a luci-milo-dev project that exists, and isn't used.  We probably want to start using this once the main instance gets real traffic.

* APIs: I assume milo exposes a JSON api similar to regular buildbot. Is that true? Is it not? If so, is it documented anywhere?
There's a planned pRPC set of endpoints (which has json mode) for the future.

* Links to docs and source: You already have a nice footer, it would be really easy to add these there.
Technically it links to https://github.com/luci, which is one click away from luci-go.  Close enough?

* CIT Feedback button: I'd like to see one, and it should be easy :)
crbug.com/642521
Cc: dsansome@chromium.org
Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?
Owner: estaab@chromium.org
Status: Assigned (was: Started)
No idea why this is assigned to agable@, but maybe that's historical. estaab@, I'm bumping this back to you to prioritize but I'm guessing this is more of a hinoka@ thing.
(And also not a p1)
Labels: -Pri-1 Pri-2
Owner: hinoka@chromium.org
Ryan, do you think you can take the rest of this from me? I think a big thing is we need to get tsmon-based alerting in place. We can talk about that separately as well.
Yep i'll be taking this
Status: WontFix (was: Assigned)

Sign in to add a comment