New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626487 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 653949



Sign in to add a comment

Update openocd to 0.10.0

Project Member Reported by dnojiri@chromium.org, Jul 7 2016

Issue description

stm32l476g-eval is used as a test harness for chromium EC CTS. It's supported by the live version (tot version) of openocd but not the latest release of openocd (0.9.0). We need to either wait for 0.10.0 release or deploy openocd-9999 now.
 

Comment 1 Deleted

https://github.com/gentoo/gentoo/blob/master/dev-embedded/openocd/openocd-9999.ebuild

openocd-9999.ebuild requires 4 packages which don't exist in the current chromium os chroot:

- sys-apps/texinfo-5+
- dev-perl/Unicode-EastAsianWidth
- dev-embedded/libjaylink
- virtual/perl-ExtUtils-MakeMaker

Some of these are build time dependencies. I'm pondering whether we should wait for 0.10.0 release and use a binary package so that we avoid introducing unnecessary build dependencies.
It turned out that openocd-9999.ebuild doesn't compile:

/usr/include/libftdi1/ftdi.h:438:12: warning: function declaration isn't a prototype [-Wstrict-prototypes]
     struct ftdi_version_info ftdi_get_library_version();
            ^
In file included from openjtag.c:80:0:
/usr/include/libftdi1/ftdi.h:438:12: warning: function declaration isn't a prototype [-Wstrict-prototypes]
     struct ftdi_version_info ftdi_get_library_version();
            ^
jlink.c: In function 'jlink_speed':
jlink.c:322:34: warning: passing argument 2 of 'jaylink_get_speeds' from incompatible pointer type
   ret = jaylink_get_speeds(devh, &freq, &divider);
                                  ^
In file included from jlink.c:42:0:
/usr/include/libjaylink/libjaylink.h:479:17: note: expected 'struct jaylink_speed *' but argument is of type 'uint32_t *'
 JAYLINK_API int jaylink_get_speeds(struct jaylink_device_handle *devh,
                 ^
jlink.c:322:9: error: too many arguments to function 'jaylink_get_speeds'
   ret = jaylink_get_speeds(devh, &freq, &divider);
         ^
In file included from jlink.c:42:0:
/usr/include/libjaylink/libjaylink.h:479:17: note: declared here
 JAYLINK_API int jaylink_get_speeds(struct jaylink_device_handle *devh,
                 ^
jlink.c: In function 'jlink_register':
jlink.c:442:8: error: too few arguments to function 'jaylink_register'
  ret = jaylink_register(devh, &conn, connlist, NULL, NULL);
        ^
In file included from jlink.c:42:0:
/usr/include/libjaylink/libjaylink.h:399:17: note: declared here
 JAYLINK_API int jaylink_register(struct jaylink_device_handle *devh,
                 ^
jlink.c: In function 'jlink_init':
jlink.c:526:2: warning: implicit declaration of function 'jaylink_get_device_list' [-Wimplicit-function-declaration]
  ret = jaylink_get_device_list(jayctx, &devs);
  ^
jlink.c:579:2: warning: implicit declaration of function 'jaylink_free_device_list' [-Wimplicit-function-declaration]
  jaylink_free_device_list(devs, 1);
  ^
jlink.c: In function 'jlink_quit':
jlink.c:742:9: error: too few arguments to function 'jaylink_unregister'
   ret = jaylink_unregister(devh, &conn, connlist, NULL, NULL);
         ^
In file included from jlink.c:42:0:
/usr/include/libjaylink/libjaylink.h:403:17: note: declared here
 JAYLINK_API int jaylink_unregister(struct jaylink_device_handle *devh,

Comment 4 by gkihumba@google.com, Mar 31 2017

Status: Assigned (was: Untriaged)
Labels: eCTS
Blocking: 653949
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fddb8e6436cbb28cd6d00d8abb1b840f8fdf7895

commit fddb8e6436cbb28cd6d00d8abb1b840f8fdf7895
Author: Daisuke Nojiri <dnojiri@chromium.org>
Date: Wed Jun 21 02:30:19 2017

openocd: Disable jlink for 0.10.0

This patch disables Segger J-Link for building openocd-0.10.0. We
currently don't use J-Link. It requires upgrading libjaylink, which
is not yet supported by official Gentoo portage repository.

Developers need to manually add plugdev to /etc/group.

BUG= chromium:626487 
TEST=Run emerge-fizz openocd and emerge openocd. cts/cts.py -m meta.

Change-Id: Ifb7fc2d3d812f9dfe00973cef48258f3709dcc06
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/540792
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/fddb8e6436cbb28cd6d00d8abb1b840f8fdf7895/profiles/targets/sdk/package.use
[modify] https://crrev.com/fddb8e6436cbb28cd6d00d8abb1b840f8fdf7895/profiles/targets/chromeos/package.use

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/e2d95c585898d9a7e71a9ef3ac180b344b27635b

commit e2d95c585898d9a7e71a9ef3ac180b344b27635b
Author: Daisuke Nojiri <dnojiri@chromium.org>
Date: Wed Jun 21 16:22:00 2017

openocd: Upgrade to 0.10.0

This patch upgrades openocd from 0.9.0 to 0.10.0. It also adds
dev-libs/hidapi as a new dependency.

Developers need to add plugdev to /etc/group manually.

BUG= chromium:626487 
TEST=run cts/cts.py -m meta. emerge openocd. emerge-fizz openocd.
CQ-DEPEND=CL:540792

Change-Id: I40c7a4f529d280e58c65f12d71609aa3089bbac5
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/540788
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e2d95c585898d9a7e71a9ef3ac180b344b27635b/dev-embedded/openocd/metadata.xml
[modify] https://crrev.com/e2d95c585898d9a7e71a9ef3ac180b344b27635b/dev-embedded/openocd/Manifest
[rename] https://crrev.com/e2d95c585898d9a7e71a9ef3ac180b344b27635b/dev-embedded/openocd/openocd-0.10.0.ebuild
[add] https://crrev.com/e2d95c585898d9a7e71a9ef3ac180b344b27635b/dev-libs/hidapi/hidapi-0.8.0_rc1_p20140719.ebuild
[add] https://crrev.com/e2d95c585898d9a7e71a9ef3ac180b344b27635b/metadata/md5-cache/dev-libs/hidapi-0.8.0_rc1_p20140719
[delete] https://crrev.com/3a78af6901abd96452d3a42bf5c616d3c6df2d3e/metadata/md5-cache/dev-embedded/openocd-0.9.0
[add] https://crrev.com/e2d95c585898d9a7e71a9ef3ac180b344b27635b/metadata/md5-cache/dev-embedded/openocd-0.10.0
[add] https://crrev.com/e2d95c585898d9a7e71a9ef3ac180b344b27635b/dev-libs/hidapi/metadata.xml
[add] https://crrev.com/e2d95c585898d9a7e71a9ef3ac180b344b27635b/dev-libs/hidapi/Manifest
[add] https://crrev.com/e2d95c585898d9a7e71a9ef3ac180b344b27635b/dev-embedded/openocd/files/openocd-0.8.0-jimtcl-0.75.patch

Status: Fixed (was: Assigned)

Sign in to add a comment