New issue
Advanced search Search tips

Issue 626486 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Audit WMPI suspend/resume paths w.r.t. HTMLMediaElement::finishSeek()

Project Member Reported by wolenetz@chromium.org, Jul 7 2016

Issue description

Looking over HTMLMediaElement.cpp, there are at least 2 paths to finishSeek() (::timeChanged(), and in ::setReadyState()) with differing logic. Only one of them checks to see if WebMediaPlayer is indeed seeking.

This bug tracks auditing and/or refactoring this code smell to make sure the more recent suspend/resume logic doesn't accidentally trigger finishSeek() with unexpected consequences (and perhaps make the code more readable and maintainable...)

sandersd@, can you take a look at this please?
 

Sign in to add a comment