Issue metadata
Sign in to add a comment
|
Make the Ash system menu audio mute button keyboard-focusable and accessible with ChromeVox
Reported by
henk.a...@gmail.com,
Jul 7 2016
|
||||||||||||||||||||||||
Issue descriptionMode: force_next Version: 53.0.2773.0 Reproduction Steps: 1. Press alt+shift+s to go to the statusbar 2.navigate accross the buttons using CVN commands 3. Where you reach the mute button, it just says Button.
,
Jul 18 2016
,
Jul 29 2016
@tdanderson, is this something you could fix easily?
,
Aug 4 2016
Based on the issue description I can't reproduce this since the Cast/screen capture row doesn't have a mute button (it has a stop button). Tom, can you loop in someone from the a11y team to take a look?
,
Aug 4 2016
The button muted the ChromeBook, not the casting, however in the latest Chrome OS the button seems to have disappeared completely. Now to the right of the cast button on the status bar, there is the volume slider for the ChromeBook, the mute button has vanished, so this maybe explains why you can't reproduce.
,
Aug 4 2016
The button is still there: 1. log in to a ChromeBook 2. press alt+shift+s to get to the status bar. 3. navigate using ChromeVox + arrow right: 4. After logoff and time etc. there is a button that says: casting 5. When you navigate one further to the right using CV+arrow, you hear the unlabeled button. 6. If you navigate further using tab in sted of via CV+arrow, the button is skipped.
,
Aug 5 2016
@tdanderson -- I believe this is the icon in the Audio row, which mutes/unmutes your device when clicked. When you navigate to it using ChromeVox, all it says is "Button".
,
Aug 10 2016
henk.abma@, thanks a lot for the details and the repro steps. CL: https://codereview.chromium.org/2234823003/ With this CL, the ChromeVox spoken feedback for this button is "Mute - Button" instead of just "Button". I'm not sure what the approval process is for spoken feedback strings, but +lpalmaro@ as FYI just in case. The keyboard focus was also buggy (it was not possible to toggle the button on/off using the Enter key) so I also addressed that problem.
,
Aug 10 2016
Thanks for taking a look! Just to further clarify, the expectation is the following repro: - ChromeVox navigate (Search+Shift+arrows right) to the mute button - it should say "mute button, not pressed") - either a click or Search+Shift+spacebar (the ChromeVox command to click the active control), should result in the widget firing an event notifying ChromeVox that an attribute has changed, which ultimately results in ChromeVox re-reading the new state of the control. In either case, it should say "mute button, pressed"; which is obviously muted, but this output would be on a braille display, if connected.
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61303af2fe0a016b69e2dfd1b8a752326d605d40 commit 61303af2fe0a016b69e2dfd1b8a752326d605d40 Author: tdanderson <tdanderson@chromium.org> Date: Thu Aug 11 16:39:05 2016 Make the mute button in the Ash system menu keyboard focusable Make the mute button in the Ash system menu keyboard focusable, and assign it the accessible name of "Mute" for ChromeVox spoken feedback. BUG= 626464 TEST=manual Review-Url: https://codereview.chromium.org/2234823003 Cr-Commit-Position: refs/heads/master@{#411355} [modify] https://crrev.com/61303af2fe0a016b69e2dfd1b8a752326d605d40/ash/ash_strings.grd [modify] https://crrev.com/61303af2fe0a016b69e2dfd1b8a752326d605d40/ash/common/system/audio/volume_view.cc
,
Aug 11 2016
,
Aug 22 2016
Mute button is focusable/speakable in: Version 54.0.2831.0 canary (64-bit)
,
Aug 22 2016
Is fixed on my ChromeBook using dev channel as well. Button is even propperly translated; great!
,
Aug 23 2016
verified on 54.0.2831.0 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lpalmaro@chromium.org
, Jul 15 2016Owner: tbuck...@chromium.org
Status: Assigned (was: Unconfirmed)