New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626458 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

WidgetTest.Transparency_DesktopWidgetInferOpacity is broken

Project Member Reported by krasin@chromium.org, Jul 7 2016

Issue description

WidgetTest.Transparency_DesktopWidgetInferOpacity and a couple of other test cases from view_unittests are broken on multiple bots:

https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5994
https://build.chromium.org/p/chromium.fyi/builders/LTO%20Linux/builds/794
https://build.chromium.org/p/chromium.fyi/builders/UBSanVptr%20Linux/builds/731

This bug was introduced on Jun 24 by https://codereview.chromium.org/1998653002 and has not been fixed since then.

We need to either fix the issue, or remove the failing test, or revert the CL.

Sorry for filing this bug so late, I just today returned from a vacation.
 
Status: Started (was: Assigned)
Thx for reporting the problem.
I made a fix already for it: https://codereview.chromium.org/2124633002/patch/130011/140010, hopefully it will land soon.
Thank you, Julien!

Comment 3 by imkra...@gmail.com, Jul 22 2016

Julien,

this was fixed after you have submitted the fix #1, but now it has regressed again:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/6147

The reason is that the fix was reverted:
https://codereview.chromium.org/2171023002/

Hi, thx for confirming that it fixed the problem. I saw it has been reverted, this is just because the 2 tests I added at the end are not meant to run on Android. I just uploaded a "Patch Set 18" https://codereview.chromium.org/2124633002/ . There is another pb with the tests on some Linux bots "TypeError: argument of type 'NoneType' is not iterable", I will have a look but this is just because the tests are faking the gl values.

Sign in to add a comment