I need more information. What do you want ios_cronet_tester to do? Does it just need to run some additional tests, or do we need to build differently?

There is 'cronet_test' target that includes tests that we would like to be able to run using a try bot. Currently, the target builds an app bundle that executes unit tests when launched (see https://cs.chromium.org/chromium/src/components/cronet.gypi?q=cronet.gyp&sq=package:chromium&l=867). It consists of the test itself cronet_bidirectional_stream_test.mm and the test runner cronet_test_runner.mm.

The tests should also be run periodically on ToT.

One important difference is that Cronet is built using different flags than Chromium. The flags are: enable_websockets=false, disable_file_support=true, disable_ftp_support=true, use_platform_icu_alternatives=true, disable_brotli_filter=true

Is there any way to get Chromium and Cronet to build together? I can't guarantee we have enough capacity to put another iOS try bot on the CQ. It would be great if we could just run all the normal unit tests and then also run cronet_test.

Ideally, Cronet should be built with its own flags to reflect the production code and improve test coverage. E.g., depending on the value of 'use_platform_icu_alternatives' flag, different classes will be instantiated and executed.

I think it may be possible to build Cronet with Chromium. It will not be the same but it will be better than nothing.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/1774d382407ac19ab0a45693d167dab42f31a88a

commit 1774d382407ac19ab0a45693d167dab42f31a88a
Author: smut <smut@google.com>
Date: Fri Jul 15 21:22:04 2016

Add ios-simulator-cronet to tryserver.chromium.mac

BUG= 626456 

Review-Url: https://codereview.chromium.org/2152103002

[modify] https://crrev.com/1774d382407ac19ab0a45693d167dab42f31a88a/masters/master.tryserver.chromium.mac/master.cfg
[modify] https://crrev.com/1774d382407ac19ab0a45693d167dab42f31a88a/masters/master.tryserver.chromium.mac/slaves.cfg

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/e35539e8a67f4abeb1d2526040b2ba94c89a9c0c

commit e35539e8a67f4abeb1d2526040b2ba94c89a9c0c
Author: smut <smut@google.com>
Date: Fri Jul 15 21:29:03 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7061be0ed182747b4d275d62677d36187b27641

commit f7061be0ed182747b4d275d62677d36187b27641
Author: smut <smut@google.com>
Date: Fri Jul 15 22:26:12 2016

Add config for ios-simulator-cronet bot

BUG= 626456 

Review-Url: https://codereview.chromium.org/2149493007
Cr-Commit-Position: refs/heads/master@{#405879}

[add] https://crrev.com/f7061be0ed182747b4d275d62677d36187b27641/ios/build/bots/chromium.mac/ios-simulator-cronet.json
[modify] https://crrev.com/f7061be0ed182747b4d275d62677d36187b27641/tools/mb/mb_config.pyl

smut@, thanks for your help! 

I've tried to test https://codereview.chromium.org/2150933007/ on ios-simulator-cronet but it doesn't seem to start. 

Any ideas? 

Slave wasn't connected. I started the buildbot slave process and it's running your try job now.

Cool, thanks for checking! It did run, but unfortunately failed to find xcode: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-cronet/builds/0

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4efe303049482f275e9fe76533db2e4fd7a5119a

commit 4efe303049482f275e9fe76533db2e4fd7a5119a
Author: smut <smut@google.com>
Date: Fri Jul 22 04:00:40 2016

Update ios-simulator-cronet to use the 9.3 SDK

BUG= 626456 

Review-Url: https://codereview.chromium.org/2169203002
Cr-Commit-Position: refs/heads/master@{#407057}

[modify] https://crrev.com/4efe303049482f275e9fe76533db2e4fd7a5119a/ios/build/bots/chromium.mac/ios-simulator-cronet.json

Try bot is set up, but compilation is failing:
https://uberchromegw.corp.google.com/i/tryserver.chromium.mac/builders/ios-simulator-cronet/builds/1
https://uberchromegw.corp.google.com/i/tryserver.chromium.mac/builders/ios-simulator-cronet/builds/3

Please fix before we can add this to CQ or main.

Sorry for the delay. It appears that bot is building all targets, which is not possible with given gn flags.

Is it possible to limit targets to a certain list (for starters cronet_test and cronet_framework would do)? 

I've tried to edit ios-simulator-cronet.json locally, but that doesn't seem to work.

It would also be useful to build and run cronet_unittests target.

Can you make src-side changes so only cronet targets get counted as "all" with cronet gn args set?

Per comments on https://groups.google.com/a/google.com/forum/#!topic/cronet-team/4NTXhSgPvdI it appears that it should be possible to limit set of build and test targets for bot on CQ.

Ping. The try bot https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-cronet is up and running, but is not very popular, and just last week cronet tests got broken by unrelated change, which we are still trying to track down.

Would it be possible to add Cronet IOS Simulator Builder / Tester to chromium.fyi waterfall (or some other), so it would detect failures in near time after they land?

Sorry for the delay, it took awhile for us to fix compilation, since the iOS bots were configured to compile all targets including ones that don't work for cronet. By the time that was fixed for all iOS bots, I forgot about this.

I think we should be able to get something on chromium.fyi soon.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec6801495d0b7eb78429671cba5e70ca5704477f

commit ec6801495d0b7eb78429671cba5e70ca5704477f
Author: smut <smut@google.com>
Date: Fri Jan 20 00:48:02 2017

Add config for ios-simulator-cronet on chromium.fyi

BUG= 626456 

Review-Url: https://codereview.chromium.org/2643753004
Cr-Commit-Position: refs/heads/master@{#444895}

[add] https://crrev.com/ec6801495d0b7eb78429671cba5e70ca5704477f/ios/build/bots/chromium.fyi/ios-simulator-cronet.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/ed5b7cf9a326e4359db9f4b563d1b0814015bc66

commit ed5b7cf9a326e4359db9f4b563d1b0814015bc66
Author: smut <smut@google.com>
Date: Thu Jan 19 23:49:25 2017

Add ios-simulator-cronet to chromium.fyi

BUG= 626456 

Change-Id: I21c4059177911dba0b731a0b3ac585593ac694bc
Reviewed-on: https://chromium-review.googlesource.com/430383
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: smut <smut@chromium.org>

[modify] https://crrev.com/ed5b7cf9a326e4359db9f4b563d1b0814015bc66/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/ed5b7cf9a326e4359db9f4b563d1b0814015bc66/masters/master.chromium.fyi/slaves.cfg

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/f29fed8b3bcb23e21c652b35087a6b4db2b0eadc

commit f29fed8b3bcb23e21c652b35087a6b4db2b0eadc
Author: smut <smut@google.com>
Date: Fri Jan 20 03:14:07 2017

https://uberchromegw.corp.google.com/i/chromium.fyi/builders/ios-simulator-cronet

Thanks a lot!