New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 626453 link

Starred by 1 user
Status: Fixed
Owner:
skobes@chromium.org
Closed: Jul 2016
Cc:
perezju@chromium.org
█ ymalik@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug-Regression



Sign in to add a comment

adb_command_line.py crashes if flags file does not exist

Project Member Reported by skobes@chromium.org, Jul 7 2016 
$ adb_chrome_public_command_line
Existing flags (in /data/local/chrome-command-line):
Traceback (most recent call last):
  File "/ssd/c/src/build/android/adb_command_line.py", line 84, in <module>
    sys.exit(main())
  File "/ssd/c/src/build/android/adb_command_line.py", line 58, in main
    print_args()
  File "/ssd/c/src/build/android/adb_command_line.py", line 51, in print_args
    flags = all_devices.pMap(read_flags).pGet(None)
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/parallelizer.py", line 236, in pMap
    r.pFinish(None)
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/parallelizer.py", line 135, in pFinish
    self._objs.JoinAll()
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 186, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 158, in _JoinAll
    thread.ReraiseIfException()
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 81, in run
    self._ret = self._func(*self._args, **self._kwargs)
  File "/ssd/c/src/build/android/adb_command_line.py", line 46, in read_flags
    return device.ReadFile(args.device_path, as_root=as_root).rstrip()
  File "/ssd/c/src/third_party/catapult/devil/devil/android/decorators.py", line 57, in timeout_retry_wrapper
    retry_if_func=retry_if_func)
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/timeout_retry.py", line 157, in Run
    error_log_func=error_log_func)
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 186, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 158, in _JoinAll
    thread.ReraiseIfException()
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 81, in run
    self._ret = self._func(*self._args, **self._kwargs)
  File "/ssd/c/src/third_party/catapult/devil/devil/utils/timeout_retry.py", line 150, in <lambda>
    child_thread = reraiser_thread.ReraiserThread(lambda: func(*args, **kwargs),
  File "/ssd/c/src/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    return f(*args, **kwargs)
  File "/ssd/c/src/third_party/catapult/devil/devil/android/device_utils.py", line 1530, in ReadFile
    and 0 < get_size(device_path) <= self._MAX_ADB_OUTPUT_LENGTH):
  File "/ssd/c/src/third_party/catapult/devil/devil/android/device_utils.py", line 1527, in get_size
    return self.FileSize(path, as_root=as_root)
  File "/ssd/c/src/third_party/catapult/devil/devil/android/device_utils.py", line 1742, in FileSize
    entry = self.StatPath(device_path, as_root=as_root, **kwargs)
  File "/ssd/c/src/third_party/catapult/devil/devil/android/device_utils.py", line 1717, in StatPath
    'Cannot find file or directory: %r' % device_path, str(self))
devil.android.device_errors.CommandFailedError: (device: 04b75cd1f0c9e8e7) Cannot find file or directory: '/data/local/chrome-command-line'

Comment 1 by skobes@chromium.org, Jul 7 2016

Cc: ymalik@chromium.org
Components: Test>Android
Labels: Type-Bug-Regression
Patch up: http://crrev.com/2132813002

Comment 2 by skobes@chromium.org, Jul 7 2016

Cc: perezju@chromium.org jbudorick@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d86ed8b58e1320c9bc8d200a225bfc06241f823

commit 3d86ed8b58e1320c9bc8d200a225bfc06241f823
Author: skobes <skobes@chromium.org>
Date: Fri Jul 08 00:48:47 2016

Fix handling of absent flags file in adb_command_line.py.

This broke in http://crrev.com/2044413002.

BUG= 626453 

Review-Url: https://codereview.chromium.org/2132813002
Cr-Commit-Position: refs/heads/master@{#404282}

[modify] https://crrev.com/3d86ed8b58e1320c9bc8d200a225bfc06241f823/build/android/adb_command_line.py

Comment 4 by perezju@chromium.org, Jul 8 2016 

Thanks for the fix!

Comment 5 by skobes@chromium.org, Jul 8 2016

Status: Fixed (was: Started)
►

Sign in to add a comment