New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626451 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Payments] Add support for half-width fields

Project Member Reported by dfalcant...@chromium.org, Jul 7 2016

Issue description

Labels: -Pri-3 OS-Android Pri-2
Labels: M-53
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce

commit 975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce
Author: dfalcantara <dfalcantara@chromium.org>
Date: Thu Jul 07 22:07:24 2016

[Payments] Update autofill/payments spacings

* The fields felt a little squished.  Try to space them out a little better.

* Update the underline colors to match the TextInputLayers.

* Add support for half width controls in the display.

Screenshots here:
https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190

BUG=603635, 626451 

Review-Url: https://codereview.chromium.org/2114493002
Cr-Commit-Position: refs/heads/master@{#404241}

[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/layout/autofill_billing_address_dropdown.xml
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/layout/autofill_local_card_editor.xml
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/layout/autofill_profile_editor.xml
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/layout/autofill_server_card_editor.xml
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/layout/payment_request_editor.xml
[add] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/layout/payment_request_editor_dropdown.xml
[add] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/layout/payment_request_editor_footer.xml
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/layout/preference_address_float_label_layout.xml
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/values-v21/styles.xml
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java
[modify] https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Labels: Merge-Request-53
Merge requesting because some important follow up CLs sit on top of this.

Comment 5 by dimu@google.com, Jul 7 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 7 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2286219348812bd01cd9c87e58308399143c9a

commit ff2286219348812bd01cd9c87e58308399143c9a
Author: dfalcantara@chromium.org <dfalcantara@chromium.org>
Date: Thu Jul 07 22:33:11 2016

[Payments] Update autofill/payments spacings

* The fields felt a little squished.  Try to space them out a little better.

* Update the underline colors to match the TextInputLayers.

* Add support for half width controls in the display.

Screenshots here:
https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190

BUG=603635, 626451 
TBR=ianwen,rouslan

Review URL: https://codereview.chromium.org/2130633004 .

Review-Url: https://codereview.chromium.org/2114493002
Cr-Original-Commit-Position: refs/heads/master@{#404241}
Cr-Commit-Position: refs/branch-heads/2785@{#48}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/layout/autofill_billing_address_dropdown.xml
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/layout/autofill_local_card_editor.xml
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/layout/autofill_profile_editor.xml
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/layout/autofill_server_card_editor.xml
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/layout/payment_request_editor.xml
[add] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/layout/payment_request_editor_dropdown.xml
[add] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/layout/payment_request_editor_footer.xml
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/layout/preference_address_float_label_layout.xml
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/values-v21/styles.xml
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java
[modify] https://crrev.com/ff2286219348812bd01cd9c87e58308399143c9a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb

commit 3c7f3e612cd4abe9153d6429501d4d1c1110a5fb
Author: gsennton <gsennton@chromium.org>
Date: Fri Jul 08 09:39:54 2016

Revert of [Payments] Update autofill/payments spacings (patchset #9 id:160001 of https://codereview.chromium.org/2114493002/ )

Reason for revert:
This patch breaks the Android Tests (dbg) bot, I've filed bug  crbug.com/626606  for this issue. It breaks in

C  857.741s Main  [FAIL] org.chromium.chrome.browser.payments.PaymentRequestFreeShippingTest#testChangeCountryAddAddressAndPay:
C  857.741s Main  java.lang.AssertionError
C  857.741s Main  	at org.chromium.chrome.browser.payments.ui.EditorView.addFieldViewToEditor(EditorView.java:293)

Original issue's description:
> [Payments] Update autofill/payments spacings
>
> * The fields felt a little squished.  Try to space them out a little better.
>
> * Update the underline colors to match the TextInputLayers.
>
> * Add support for half width controls in the display.
>
> Screenshots here:
> https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190
>
> BUG=603635, 626451 
>
> Committed: https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce
> Cr-Commit-Position: refs/heads/master@{#404241}

TBR=rouslan@chromium.org,ianwen@chromium.org,dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603635, 626451 

Review-Url: https://codereview.chromium.org/2137443002
Cr-Commit-Position: refs/heads/master@{#404331}

[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/res/layout/autofill_billing_address_dropdown.xml
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/res/layout/autofill_local_card_editor.xml
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/res/layout/autofill_profile_editor.xml
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/res/layout/autofill_server_card_editor.xml
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/res/layout/payment_request_editor.xml
[delete] https://crrev.com/b13637b2ffc6aca611a407e943ffe587ab7e4aa2/chrome/android/java/res/layout/payment_request_editor_dropdown.xml
[delete] https://crrev.com/b13637b2ffc6aca611a407e943ffe587ab7e4aa2/chrome/android/java/res/layout/payment_request_editor_footer.xml
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/res/layout/preference_address_float_label_layout.xml
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/res/values-v21/styles.xml
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java
[modify] https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Status: Assigned (was: Fixed)
I had to revert this on ToT because it is breaking Android Tests (dbg) :(, dfalcantara@ I see that this was merged to M53 as well, I believe we should revert it from that branch as well?
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daffeb624ad9883cdb689cc813e8cf013c1f85ec

commit daffeb624ad9883cdb689cc813e8cf013c1f85ec
Author: gsennton <gsennton@chromium.org>
Date: Fri Jul 08 10:19:40 2016

Revert of [Payments] Update autofill/payments spacings (patchset #1 id:1 of https://codereview.chromium.org/2130633004/ )

Reason for revert:
The ToT version of this patch breaks the Android Tests (dbg) bot, I've filed bug  crbug.com/626606  for this issue and reverted that patch (see https://codereview.chromium.org/2137443002). I'm now reverting this patch as well to keep this branch consistent.

Original issue's description:
> [Payments] Update autofill/payments spacings
>
> * The fields felt a little squished.  Try to space them out a little better.
>
> * Update the underline colors to match the TextInputLayers.
>
> * Add support for half width controls in the display.
>
> Screenshots here:
> https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190
>
> BUG=603635, 626451 
> TBR=ianwen,rouslan
>
> Review-Url: https://codereview.chromium.org/2114493002
> Cr-Commit-Position: refs/heads/master@{#404241}
> Committed: https://chromium.googlesource.com/chromium/src/+/ff2286219348812bd01cd9c87e58308399143c9a

TBR=ianwen@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603635, 626451 

Review-Url: https://codereview.chromium.org/2133113002
Cr-Commit-Position: refs/branch-heads/2785@{#58}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/res/layout/autofill_billing_address_dropdown.xml
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/res/layout/autofill_local_card_editor.xml
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/res/layout/autofill_profile_editor.xml
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/res/layout/autofill_server_card_editor.xml
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/res/layout/payment_request_editor.xml
[delete] https://crrev.com/75fc84ae9e84360b4c4fa06d5028aec5eed3517d/chrome/android/java/res/layout/payment_request_editor_dropdown.xml
[delete] https://crrev.com/75fc84ae9e84360b4c4fa06d5028aec5eed3517d/chrome/android/java/res/layout/payment_request_editor_footer.xml
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/res/layout/preference_address_float_label_layout.xml
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/res/values-v21/styles.xml
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java
[modify] https://crrev.com/daffeb624ad9883cdb689cc813e8cf013c1f85ec/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

This has now been reverted both on ToT and 53.
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/815e8e8ecdfbbf1da2ef5ab958834b1644013911

commit 815e8e8ecdfbbf1da2ef5ab958834b1644013911
Author: dfalcantara <dfalcantara@chromium.org>
Date: Fri Jul 08 18:27:36 2016

[Payments] Update autofill/payments spacings

* The fields felt a little squished.  Try to space them out a little better.

* Update the underline colors to match the TextInputLayers.

* Add support for half width controls in the display.

Screenshots here:
https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190

BUG=603635, 626451 

Committed: https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce
Review-Url: https://codereview.chromium.org/2114493002
Cr-Original-Commit-Position: refs/heads/master@{#404241}
Cr-Commit-Position: refs/heads/master@{#404446}

[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/layout/autofill_billing_address_dropdown.xml
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/layout/autofill_local_card_editor.xml
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/layout/autofill_profile_editor.xml
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/layout/autofill_server_card_editor.xml
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/layout/payment_request_editor.xml
[add] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/layout/payment_request_editor_dropdown.xml
[add] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/layout/payment_request_editor_footer.xml
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/layout/preference_address_float_label_layout.xml
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/values-v21/styles.xml
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java
[modify] https://crrev.com/815e8e8ecdfbbf1da2ef5ab958834b1644013911/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Labels: -Hotlist-Merge-Approved -merge-merged-2785 Merge-Request-53
Re-requesting a merge after fixing the assert.

Comment 14 by dimu@google.com, Jul 8 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 8 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29dd8f9bb484090f141f855cd96c3d4c8b9af771

commit 29dd8f9bb484090f141f855cd96c3d4c8b9af771
Author: dfalcantara@chromium.org <dfalcantara@chromium.org>
Date: Fri Jul 08 20:03:07 2016

[Payments] Update autofill/payments spacings

* The fields felt a little squished.  Try to space them out a little better.

* Update the underline colors to match the TextInputLayers.

* Add support for half width controls in the display.

Screenshots here:
https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190

BUG=603635, 626451 
TBR=rouslan,ianwen

Review URL: https://codereview.chromium.org/2129293002 .

Committed: https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce
Review-Url: https://codereview.chromium.org/2114493002
Cr-Original-Original-Commit-Position: refs/heads/master@{#404241}
Cr-Original-Commit-Position: refs/heads/master@{#404446}
Cr-Commit-Position: refs/branch-heads/2785@{#60}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/layout/autofill_billing_address_dropdown.xml
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/layout/autofill_local_card_editor.xml
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/layout/autofill_profile_editor.xml
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/layout/autofill_server_card_editor.xml
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/layout/payment_request_editor.xml
[add] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/layout/payment_request_editor_dropdown.xml
[add] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/layout/payment_request_editor_footer.xml
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/layout/preference_address_float_label_layout.xml
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/values-v21/styles.xml
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java
[modify] https://crrev.com/29dd8f9bb484090f141f855cd96c3d4c8b9af771/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Status: Fixed (was: Assigned)
Really fixed this time, hopefully.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment