Issue 626449 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	rtoy@chromium.org
Closed:	Sep 2016
Components:	Blink>WebAudio
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Feature
merge-merged-2883

Blocking:
issue 565510

Implement constructors for WebAudio nodes

Project Member Reported by rtoy@chromium.org, Jul 7 2016

Issue description

Constructors are being added for WebAudio nodes.

WebAudio issue: https://github.com/WebAudio/web-audio-api/issues/696

Comment 1 by hyungwoo...@navercorp.com, Jul 25 2016

Can I take this issue?

Comment 2 by rtoy@chromium.org, Jul 25 2016

As before, if it's not assigned to any one, you can assign it to yourself and just do it.

However, see https://codereview.chromium.org/2102133002.  This isn't ready to land because there are some open issues with the spec on exactly what the constructors look like.  And this change needs an intent to implement and ship document sent to blink-dev.

Comment 3 by hyungwoo...@navercorp.com, Jul 26 2016

I do not have permission to assign bugs to me.
Could you help me to get right permission to edit chromium bug system?

Comment 4 by rtoy@chromium.org, Jul 26 2016

Ok. First, look at https://www.chromium.org/getting-involved/get-bug-editing-privileges

Until then, just leave a message on the bugs saying you want to work on the issue, as you've been currently doing.

Comment 5 by rtoy@chromium.org, Sep 9 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57909df69be0cf0b2ac42e5c9c018d4a00ee9766

commit 57909df69be0cf0b2ac42e5c9c018d4a00ee9766
Author: rtoy <rtoy@chromium.org>
Date: Fri Sep 16 17:06:54 2016

Add constructors for WebAudio nodes

In addition to the existing createFoo() to create an AudioNode, we add support for
new FooNode(context, options).  The options argument is a dictionary
specific to the node and is also defined here.

Tests added for the basic functionality for constructing the nodes
and for testing that the required arguments (if any) are processed correctly.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuuAAAJ
Feature: https://www.chromestatus.com/features/6409704485945344

BUG= 626449 
TEST=constructor/*.html

Review-Url: https://codereview.chromium.org/2102133002
Cr-Commit-Position: refs/heads/master@{#419195}

[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/audionodeoptions.js
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/biquadfilter.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/delay.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/dynamicscompressor.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/gain.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/iirfilter.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/panner.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/constructor/waveshaper.html
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AnalyserNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AnalyserNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AnalyserOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioBuffer.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioBufferOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioContext.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioListener.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioNodeOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioParam.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/BiquadFilterOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ChannelMergerOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ChannelSplitterOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ConvolverNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ConvolverOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/DelayNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/DelayNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/DelayOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/GainNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/GainNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/GainOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/IIRFilterOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/OscillatorNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/OscillatorOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/PannerNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/PannerNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/PannerOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/PeriodicWave.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/PeriodicWave.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/PeriodicWaveConstraints.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/PeriodicWaveOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/StereoPannerOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.idl
[add] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/WaveShaperOptions.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.cpp
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl
[modify] https://crrev.com/57909df69be0cf0b2ac42e5c9c018d4a00ee9766/tools/metrics/histograms/histograms.xml

Comment 7 by iclell...@chromium.org, Sep 16 2016

A test failure with this patch caused the MacOS 10.11 builder to fail. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=webaudio%2Fconstructor%2Fperiodicwave.html&testType=webkit_tests

Not reverting automatically; rtoy@ is preparing a patch to fix the offending test.

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fd94044ffa82dcc6b189d86b51ee9bfa2c8ce2b

commit 0fd94044ffa82dcc6b189d86b51ee9bfa2c8ce2b
Author: rtoy <rtoy@chromium.org>
Date: Fri Sep 16 22:35:26 2016

Adjust test thresholds for OSX 10.11

Slightly increase some thresholds for tests that were failing on OSX
10.11.

TBR=hongchan@chromium.org
BUG= 626449 
TEST=constructor/periodicwave.html

Review-Url: https://codereview.chromium.org/2345913004
Cr-Commit-Position: refs/heads/master@{#419307}

[modify] https://crrev.com/0fd94044ffa82dcc6b189d86b51ee9bfa2c8ce2b/third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c1f36dce5382b5461570efea3917b54e9125a0a

commit 5c1f36dce5382b5461570efea3917b54e9125a0a
Author: fs <fs@opera.com>
Date: Sat Sep 17 22:25:40 2016

ConvolverOptions.buffer should be nullable

TBR=rtoy@chromium.org,foolip@chromium.org
BUG= 626449 , 647693 

Review-Url: https://codereview.chromium.org/2352463002
Cr-Commit-Position: refs/heads/master@{#419388}

[modify] https://crrev.com/5c1f36dce5382b5461570efea3917b54e9125a0a/third_party/WebKit/Source/modules/webaudio/ConvolverOptions.idl

Comment 10 by rtoy@chromium.org, Sep 19 2016

Status: Fixed (was: Started)

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2582f835f9351586c831e87b0cf69318cf6c971e

commit 2582f835f9351586c831e87b0cf69318cf6c971e
Author: rtoy <rtoy@chromium.org>
Date: Tue Sep 20 18:52:42 2016

AudioBufferSourceOptions.buffer should be nullable.

It's valid to set the buffer to null in the constructor.

Also added a test for ConvolverOptions which has the same issue, which
was updated in https://codereview.chromium.org/2352463002/

Spec issue: https://github.com/WebAudio/web-audio-api/issues/980

BUG= 648283 ,  626449 ,  647693 
TEST=constructor/audiobuffersource.html, constructor/convolver.html

Review-Url: https://codereview.chromium.org/2348373002
Cr-Commit-Position: refs/heads/master@{#419830}

[modify] https://crrev.com/2582f835f9351586c831e87b0cf69318cf6c971e/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
[modify] https://crrev.com/2582f835f9351586c831e87b0cf69318cf6c971e/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
[modify] https://crrev.com/2582f835f9351586c831e87b0cf69318cf6c971e/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceOptions.idl

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05b49ea11c1011743e9665dbc294fac169b6ec76

commit 05b49ea11c1011743e9665dbc294fac169b6ec76
Author: rtoy <rtoy@chromium.org>
Date: Mon Oct 10 17:16:03 2016

Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

The original intent and feature:
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuuAAAJ
Feature: https://www.chromestatus.com/features/6409704485945344

BUG= 653129 , 626449 
TEST=constructor/mediastreamaudiosource.html

Review-Url: https://codereview.chromium.org/2398713002
Cr-Commit-Position: refs/heads/master@{#424174}

[add] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html
[modify] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp
[modify] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h
[modify] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.idl
[add] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceOptions.idl

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 18 2016

Labels: merge-merged-2883

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24bb7c9279f106b90da36e915de49b1bf65585dc

commit 24bb7c9279f106b90da36e915de49b1bf65585dc
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Oct 18 17:19:30 2016

Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

The original intent and feature:
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuuAAAJ
Feature: https://www.chromestatus.com/features/6409704485945344

BUG= 653129 , 626449 
TEST=constructor/mediastreamaudiosource.html

Review-Url: https://codereview.chromium.org/2398713002
Cr-Commit-Position: refs/heads/master@{#424174}
(cherry picked from commit 05b49ea11c1011743e9665dbc294fac169b6ec76)

Review URL: https://codereview.chromium.org/2431653003 .

Cr-Commit-Position: refs/branch-heads/2883@{#177}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html
[modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp
[modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h
[modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.idl
[add] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceOptions.idl

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24bb7c9279f106b90da36e915de49b1bf65585dc

commit 24bb7c9279f106b90da36e915de49b1bf65585dc
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Oct 18 17:19:30 2016

Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

The original intent and feature:
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuuAAAJ
Feature: https://www.chromestatus.com/features/6409704485945344

BUG= 653129 , 626449 
TEST=constructor/mediastreamaudiosource.html

Review-Url: https://codereview.chromium.org/2398713002
Cr-Commit-Position: refs/heads/master@{#424174}
(cherry picked from commit 05b49ea11c1011743e9665dbc294fac169b6ec76)

Review URL: https://codereview.chromium.org/2431653003 .

Cr-Commit-Position: refs/branch-heads/2883@{#177}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html
[modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp
[modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h
[modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.idl
[add] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceOptions.idl

Comment 15 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840

[Automated comment] removing mislabelled merge-merged-2840

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b308a54ce405471a43e12ea7a65952439127d17

commit 7b308a54ce405471a43e12ea7a65952439127d17
Author: rtoy <rtoy@chromium.org>
Date: Tue Dec 20 17:23:47 2016

Add constructor for MediaStreamAudioDestinationNode

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in  issue 626449 .

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG= 674508 ,  626449 
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html

Review-Url: https://codereview.chromium.org/2578243002
Cr-Commit-Position: refs/heads/master@{#439833}

[modify] https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode-expected.txt
[modify] https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode.html
[add] https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17/third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiodestination.html
[modify] https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h
[modify] https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.idl
[modify] https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17/tools/metrics/histograms/histograms.xml

►

Issue 626449 link

Issue metadata

Implement constructors for WebAudio nodes

Issue description

Comment 1 by hyungwoo...@navercorp.com, Jul 25 2016

Comment 1 Deleted

Comment 2 by rtoy@chromium.org, Jul 25 2016

Comment 2 Deleted

Comment 3 by hyungwoo...@navercorp.com, Jul 26 2016

Comment 3 Deleted

Comment 4 by rtoy@chromium.org, Jul 26 2016

Comment 4 Deleted

Comment 5 by rtoy@chromium.org, Sep 9 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Sep 16 2016

Comment 6 Deleted

Comment 7 by iclell...@chromium.org, Sep 16 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Sep 16 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Sep 17 2016

Comment 9 Deleted

Comment 10 by rtoy@chromium.org, Sep 19 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Sep 20 2016

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Oct 10 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Oct 18 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Oct 27 2016

Comment 14 Deleted

Comment 15 by dimu@google.com, Nov 4 2016

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Dec 20 2016

Comment 16 Deleted

Sign in to add a comment