Allow arc app to lock screen in Tablet (aka Touch view) mode |
||||||||||
Issue descriptionArc app should be able to lock the screen in tablet mode. This is a chrome side bug to track b/28341028.
,
Jul 7 2016
,
Jul 7 2016
,
Jul 8 2016
#CBC-RS/TC-watchlist
,
Jul 8 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41c090842fe6ec0a457cb92998336f2884b6e5c2 commit 41c090842fe6ec0a457cb92998336f2884b6e5c2 Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Jul 11 22:04:40 2016 Allow arc app to lock screen orientation in TouchView/Tablet mode mojo change: * Added orientation lock parameter to AppInfo * Added OnTaskOrientationLockRequested method on AppHost c++ change: * Apply orientation lock to arc windows upon Tablet mode entry * Unset lock and set the rotation back upon Tablet mode exit. * Apply the rotation lock when a task requested. This is kept only on memory and does not persist. BUG= 626445 ,b/28341028 TEST=ChromeLauncherControllerImplTest.ArcOrientatinoLock Review-Url: https://codereview.chromium.org/2112013002 Cr-Commit-Position: refs/heads/master@{#404244} (cherry picked from commit 342f3485150be7e10404671e811d9c881f8b62ea) Review URL: https://codereview.chromium.org/2140843002 . Cr-Commit-Position: refs/branch-heads/2785@{#92} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/41c090842fe6ec0a457cb92998336f2884b6e5c2/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/41c090842fe6ec0a457cb92998336f2884b6e5c2/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/41c090842fe6ec0a457cb92998336f2884b6e5c2/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/41c090842fe6ec0a457cb92998336f2884b6e5c2/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h [modify] https://crrev.com/41c090842fe6ec0a457cb92998336f2884b6e5c2/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/41c090842fe6ec0a457cb92998336f2884b6e5c2/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/41c090842fe6ec0a457cb92998336f2884b6e5c2/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc [modify] https://crrev.com/41c090842fe6ec0a457cb92998336f2884b6e5c2/components/arc/common/app.mojom [modify] https://crrev.com/41c090842fe6ec0a457cb92998336f2884b6e5c2/components/exo/wayland/server.cc
,
Jul 14 2016
One more CL needs to be merged. Committed: https://chromium.googlesource.com/chromium/src/+/e5b8865795165551c8b0427d07b1e3f40067663b Add CURRENT lock orientation. * This also updates the API version: The CL was rebased prior to land, which was accidentally merged with another CL that added version 12. These APIs that I added haven't implemented yet, so it should be safe to update. BUG=b/28341028 TEST=covered by unit tests. R=rickyz@chromium.org, xiyuan@chromium.org Review URL: https://codereview.chromium.org/2139893002 . Cr-Commit-Position: refs/heads/master@{#404853} chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc[diff] chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc[diff] components/arc/common/app.mojom[diff] 3 files changed
,
Jul 14 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 14 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 18 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 20 2016
,
Jul 20 2016
,
Oct 4 2016
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 7 2016