The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d08afd67d6c706fa47d5633187687e690b2fed0

commit 4d08afd67d6c706fa47d5633187687e690b2fed0
Author: mathp <mathp@chromium.org>
Date: Fri Jul 08 19:54:10 2016

[Autofill] Implement Credit Card Signin Promo

A follow-up change will split the slightly long promo over 2-lines for Views, Mac, Android.

Also, Android and iOS will need bridges into Java and ObjC, so this is deferred to another change.

BUG= 626442 

Review-Url: https://codereview.chromium.org/2124343002
Cr-Commit-Position: refs/heads/master@{#404470}

[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/chrome/browser/ui/webui/signin/inline_login_handler.cc
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/autofill_external_delegate.h
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/popup_item_ids.h
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/autofill_strings.grdp
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/components/signin/core/browser/signin_metrics.h
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/tools/metrics/actions/actions.xml
[modify] https://crrev.com/4d08afd67d6c706fa47d5633187687e690b2fed0/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43ae237501171599b27c1b7a52c8b6df3914b963

commit 43ae237501171599b27c1b7a52c8b6df3914b963
Author: mathp <mathp@chromium.org>
Date: Tue Jul 12 19:40:26 2016

[Autofill] Change string for Credit Card sign-in promo.

BUG= 626442 
TEST=none

Review-Url: https://codereview.chromium.org/2145573003
Cr-Commit-Position: refs/heads/master@{#404825}

[modify] https://crrev.com/43ae237501171599b27c1b7a52c8b6df3914b963/components/autofill_strings.grdp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc796c2e1a81908ac9731d549db334617a663b8

commit 6dc796c2e1a81908ac9731d549db334617a663b8
Author: mathp <mathp@chromium.org>
Date: Wed Jul 13 03:30:09 2016

[Autofill] Implement Impression metric for signin promo in CC dropdown.

BUG= 626442 
TEST=AutofillExternalDelegateTest

Review-Url: https://codereview.chromium.org/2137153002
Cr-Commit-Position: refs/heads/master@{#404963}

[modify] https://crrev.com/6dc796c2e1a81908ac9731d549db334617a663b8/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/6dc796c2e1a81908ac9731d549db334617a663b8/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/6dc796c2e1a81908ac9731d549db334617a663b8/tools/metrics/actions/actions.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc796c2e1a81908ac9731d549db334617a663b8

commit 6dc796c2e1a81908ac9731d549db334617a663b8
Author: mathp <mathp@chromium.org>
Date: Wed Jul 13 03:30:09 2016

[Autofill] Implement Impression metric for signin promo in CC dropdown.

BUG= 626442 
TEST=AutofillExternalDelegateTest

Review-Url: https://codereview.chromium.org/2137153002
Cr-Commit-Position: refs/heads/master@{#404963}

[modify] https://crrev.com/6dc796c2e1a81908ac9731d549db334617a663b8/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/6dc796c2e1a81908ac9731d549db334617a663b8/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/6dc796c2e1a81908ac9731d549db334617a663b8/tools/metrics/actions/actions.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97020bfe9122ac4e0c0ede110b328db5d1193037

commit 97020bfe9122ac4e0c0ede110b328db5d1193037
Author: mathp <mathp@chromium.org>
Date: Thu Jul 14 23:05:25 2016

Now behind a Feature and also will not show if the number of impressions is higher than some value passed by Variations params.

BUG= 626442 
TEST=AutofillManagerTest

Review-Url: https://codereview.chromium.org/2146823003
Cr-Commit-Position: refs/heads/master@{#405615}

[modify] https://crrev.com/97020bfe9122ac4e0c0ede110b328db5d1193037/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/97020bfe9122ac4e0c0ede110b328db5d1193037/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/97020bfe9122ac4e0c0ede110b328db5d1193037/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/97020bfe9122ac4e0c0ede110b328db5d1193037/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/97020bfe9122ac4e0c0ede110b328db5d1193037/components/autofill/core/common/autofill_pref_names.cc
[modify] https://crrev.com/97020bfe9122ac4e0c0ede110b328db5d1193037/components/autofill/core/common/autofill_pref_names.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fc9f535f390b2d82d7308af7c3611cff248dc3a

commit 3fc9f535f390b2d82d7308af7c3611cff248dc3a
Author: mathp <mathp@chromium.org>
Date: Mon Jul 18 19:47:15 2016

[Autofill] Tweak credit card signin promo visually.

Smaller font and light grey background.

BUG= 626442 
TEST=manual

Review-Url: https://codereview.chromium.org/2152243002
Cr-Commit-Position: refs/heads/master@{#406070}

[modify] https://crrev.com/3fc9f535f390b2d82d7308af7c3611cff248dc3a/chrome/browser/ui/autofill/autofill_popup_controller.h
[modify] https://crrev.com/3fc9f535f390b2d82d7308af7c3611cff248dc3a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/3fc9f535f390b2d82d7308af7c3611cff248dc3a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
[modify] https://crrev.com/3fc9f535f390b2d82d7308af7c3611cff248dc3a/chrome/browser/ui/autofill/popup_constants.h
[modify] https://crrev.com/3fc9f535f390b2d82d7308af7c3611cff248dc3a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
[modify] https://crrev.com/3fc9f535f390b2d82d7308af7c3611cff248dc3a/chrome/browser/ui/views/autofill/autofill_popup_base_view.h
[modify] https://crrev.com/3fc9f535f390b2d82d7308af7c3611cff248dc3a/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

Tested the same on mac 10.11.5 chrome version 54.0.2800.0 without signing in to chrome and observed no signin promo in credit card drop down - Please find the screenshot

mathp@chromium.org, Could you please let us know if i am missing something here.

Deleted: Screen Shot 2016-07-19 at 4.42.39 PM.png 75.0 KB

	Screen Shot 2016-07-19 at 4.42.39 PM.png 75.0 KB View Download

Not testable yet unless you use the flag --enable-features=AutofillCreditCardSigninPromo

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7161859bb9790555239d3a8384d188a6d33fbae2

commit 7161859bb9790555239d3a8384d188a6d33fbae2
Author: mathp <mathp@chromium.org>
Date: Wed Jul 20 18:10:40 2016

[Autofill] Use AutofillPopupController::GetBackgroundColorForRow on Mac.

Kept the Mac system color for highlighting a row.

BUG= 626442 
TEST=Visual

Review-Url: https://codereview.chromium.org/2167693002
Cr-Commit-Position: refs/heads/master@{#406619}

[modify] https://crrev.com/7161859bb9790555239d3a8384d188a6d33fbae2/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7161859bb9790555239d3a8384d188a6d33fbae2

commit 7161859bb9790555239d3a8384d188a6d33fbae2
Author: mathp <mathp@chromium.org>
Date: Wed Jul 20 18:10:40 2016

[Autofill] Use AutofillPopupController::GetBackgroundColorForRow on Mac.

Kept the Mac system color for highlighting a row.

BUG= 626442 
TEST=Visual

Review-Url: https://codereview.chromium.org/2167693002
Cr-Commit-Position: refs/heads/master@{#406619}

[modify] https://crrev.com/7161859bb9790555239d3a8384d188a6d33fbae2/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

Here's how it looks on desktop. I find the grey quite light. 

Deleted: Screen Shot 2016-07-21 at 10.44.54 AM.png 24.6 KB

	Screen Shot 2016-07-21 at 10.44.54 AM.png 24.6 KB View Download

hwi@: Do you want to go ahead with this grey: #FAFAFA.

Thanks

Ping hwi@

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d130d0c01fac4ac3867b9f2458d307eb894862c

commit 4d130d0c01fac4ac3867b9f2458d307eb894862c
Author: mathp <mathp@chromium.org>
Date: Tue Aug 02 18:23:27 2016

[Autofill] Add an entry to chrome://flags for the Autofill CC signin promo

BUG= 626442 
TEST=None

Review-Url: https://codereview.chromium.org/2202323002
Cr-Commit-Position: refs/heads/master@{#409250}

[modify] https://crrev.com/4d130d0c01fac4ac3867b9f2458d307eb894862c/chrome/app/generated_resources.grd
[modify] https://crrev.com/4d130d0c01fac4ac3867b9f2458d307eb894862c/chrome/browser/about_flags.cc

Shall we change with the following?
1. The font size to the same size as "Chrome Autofill settings..."
2. No bg color

A question on "wrapping": is there any max width limit of the autofill container we can utilize (e.g. set max width to 256px) in today's world? 

Apologies for flip flopping and for getting back to this so late.

Deleted: change.png 94.0 KB

	change.png 94.0 KB View Download

Unfortunately no wrapping can be done at this point. Sorry again.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d115ca02cd675e99deb36a66a273468f78ed7360

commit d115ca02cd675e99deb36a66a273468f78ed7360
Author: mathp <mathp@chromium.org>
Date: Wed Aug 03 14:15:14 2016

[Autofill] Credit Card Signin promo: no bg color, no smaller font.

BUG= 626442 
TEST=manual

Review-Url: https://codereview.chromium.org/2203963002
Cr-Commit-Position: refs/heads/master@{#409507}

[modify] https://crrev.com/d115ca02cd675e99deb36a66a273468f78ed7360/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/d115ca02cd675e99deb36a66a273468f78ed7360/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/d115ca02cd675e99deb36a66a273468f78ed7360/chrome/browser/ui/autofill/popup_constants.h
[modify] https://crrev.com/d115ca02cd675e99deb36a66a273468f78ed7360/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a74a9962ef4361dbd4a35152891d668ac6418ad

commit 8a74a9962ef4361dbd4a35152891d668ac6418ad
Author: mathp <mathp@chromium.org>
Date: Wed Aug 03 16:21:17 2016

[Autofill] Autofill CC signin promo: flag for all platforms.

Made a mistake, should be available to all platforms.

BUG= 626442 
TEST=manual

Review-Url: https://codereview.chromium.org/2201163003
Cr-Commit-Position: refs/heads/master@{#409524}

[modify] https://crrev.com/8a74a9962ef4361dbd4a35152891d668ac6418ad/chrome/app/generated_resources.grd
[modify] https://crrev.com/8a74a9962ef4361dbd4a35152891d668ac6418ad/chrome/browser/about_flags.cc

Tested the same on mac 10.11.5, win7,8.1 using chrome version 54.0.2824.0 and Linux using chrome version 54.0.2823.0 with the flag --enable-features=AutofillCreditCardSigninPromo - Observed the signin promo as expected

Please find the screenshot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a64f430204b0c25369b2b4130dfa4b838dbf6e16

commit a64f430204b0c25369b2b4130dfa4b838dbf6e16
Author: mathp <mathp@chromium.org>
Date: Wed Nov 02 21:55:40 2016

[Autofill] Credit card signin promo: do not require a local suggestion

Previously was requiring a local credit card suggestions before showing the
promo. Now it can show when there are no credit card suggestions.

BUG= 626442 
TEST=AutofillManager,AutofillExternalDelegate

Review-Url: https://codereview.chromium.org/2473493002
Cr-Commit-Position: refs/heads/master@{#429413}

[modify] https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16/components/autofill/core/browser/autofill_external_delegate.h
[modify] https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16/components/autofill/core/browser/autofill_manager_unittest.cc

Thanks Mathieu! To be clear: can we change the behavior so we *only* show the promo when there are no cards available (and not show it when there are >=1 local cards available)?

Ok.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4f3f03b38c8003fa2a9743c73c8104abe563f33

commit f4f3f03b38c8003fa2a9743c73c8104abe563f33
Author: mathp <mathp@chromium.org>
Date: Thu Nov 03 17:31:01 2016

[Autofill] Do not show the credit card promo if there are CC suggestions.

Will now only show the promo if there are no local card suggestions.

BUG= 626442 
TEST=AutofillManager,AutofillExternalDelegate

Review-Url: https://codereview.chromium.org/2475663002
Cr-Commit-Position: refs/heads/master@{#429630}

[modify] https://crrev.com/f4f3f03b38c8003fa2a9743c73c8104abe563f33/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/f4f3f03b38c8003fa2a9743c73c8104abe563f33/components/autofill/core/browser/autofill_external_delegate_unittest.cc

Great, thanks Mathieu. Any chance we could merge this back to 55?

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35c44c94604f879ae637fc942274cf528db57ed6

commit 35c44c94604f879ae637fc942274cf528db57ed6
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Nov 04 18:16:08 2016

[Merge M55] [Autofill] Credit card signin promo: do not require a local suggestion

Previously was requiring a local credit card suggestions before showing the
promo. Now it can show when there are no credit card suggestions.

BUG= 626442 
TEST=AutofillManager,AutofillExternalDelegate

Review URL: https://codereview.chromium.org/2478013004 .

Cr-Commit-Position: refs/branch-heads/2883@{#457}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/35c44c94604f879ae637fc942274cf528db57ed6/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/35c44c94604f879ae637fc942274cf528db57ed6/components/autofill/core/browser/autofill_external_delegate.h
[modify] https://crrev.com/35c44c94604f879ae637fc942274cf528db57ed6/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/35c44c94604f879ae637fc942274cf528db57ed6/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/35c44c94604f879ae637fc942274cf528db57ed6/components/autofill/core/browser/autofill_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f133859dc5186e1870863ae540a5abde766ad063

commit f133859dc5186e1870863ae540a5abde766ad063
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Nov 04 18:22:19 2016

[Merge M55] [Autofill] Do not show the credit card promo if there are CC suggestions.

Will now only show the promo if there are no local card suggestions.

BUG= 626442 
TEST=AutofillManager,AutofillExternalDelegate

Review-Url: https://codereview.chromium.org/2475663002
Cr-Commit-Position: refs/heads/master@{#429630}
(cherry picked from commit f4f3f03b38c8003fa2a9743c73c8104abe563f33)

Review URL: https://codereview.chromium.org/2481493002 .

Cr-Commit-Position: refs/branch-heads/2883@{#458}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/f133859dc5186e1870863ae540a5abde766ad063/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/f133859dc5186e1870863ae540a5abde766ad063/components/autofill/core/browser/autofill_external_delegate_unittest.cc

"Chrome on Android" -> Tested on M55-55.0.2883.41 with enable the flag "Enable Autofill Credit Card Signin Promo" - Please find the attached screenshot

Deleted: Screenshot_20161107-134442 (1).png 134 KB

	Screenshot_20161107-134442 (1).png 134 KB View Download

Great, thanks kravula@! Could you confirm that when you have at least 1 locally saved card, no promo appears?

And could someone test this on desktop to make sure the same thing works?

Tested the same on win10, mac and Linux chrome version 55.0.2883.44 - Observed that Credit card signin promo shows when there are no suggestions - Please find the screenshot

No promo seen when there are locally saved cards - Please find the screenshot

Adding TE-Verified labels

Deleted: Screen Shot 2016-11-09 at 1.16.50 PM.png 125 KB

	Screen Shot 2016-11-09 at 1.16.50 PM.png 125 KB View Download

Deleted: Screen Shot 2016-11-09 at 1.32.01 PM.png 199 KB

	Screen Shot 2016-11-09 at 1.32.01 PM.png 199 KB View Download