New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626439 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Team-Accessibility

Blocking:
issue 594887
issue 557401



Sign in to add a comment

mus needs support for high-contrast mode

Project Member Reported by sadrul@chromium.org, Jul 7 2016

Issue description

ChromeOS has a high-contrast mode for accessibility. We need to support this in mus.

The way it currently works is by setting a filter on the root layer (https://cs.chromium.org/chromium/src/ash/high_contrast/high_contrast_controller.cc?type=cs&sq=package:chromium&l=35). Instead of doing this from each client, we need to do this in mus (because otherwise we can end up with some clients not bothering to do this).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05ee8278913d7012f5216505e243d1b5b2728ba6

commit 05ee8278913d7012f5216505e243d1b5b2728ba6
Author: sadrul <sadrul@chromium.org>
Date: Wed Jul 13 03:52:10 2016

mus: Introduce high-contrast mode in mus.

BUG=626439

Review-Url: https://codereview.chromium.org/2127383003
Cr-Commit-Position: refs/heads/master@{#404985}

[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/ash/mus/manifest.json
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/ash/mus/window_manager.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/public/interfaces/BUILD.gn
[add] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/public/interfaces/accessibility_manager.mojom
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/service.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/service.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/BUILD.gn
[add] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/accessibility_manager.cc
[add] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/accessibility_manager.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/display.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/display.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/frame_generator_delegate.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/platform_display.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/platform_display.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/platform_display_delegate.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/test_utils.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/test_utils.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/window_server.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/window_server.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05ee8278913d7012f5216505e243d1b5b2728ba6

commit 05ee8278913d7012f5216505e243d1b5b2728ba6
Author: sadrul <sadrul@chromium.org>
Date: Wed Jul 13 03:52:10 2016

mus: Introduce high-contrast mode in mus.

BUG=626439

Review-Url: https://codereview.chromium.org/2127383003
Cr-Commit-Position: refs/heads/master@{#404985}

[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/ash/mus/manifest.json
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/ash/mus/window_manager.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/public/interfaces/BUILD.gn
[add] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/public/interfaces/accessibility_manager.mojom
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/service.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/service.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/BUILD.gn
[add] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/accessibility_manager.cc
[add] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/accessibility_manager.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/display.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/display.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/frame_generator_delegate.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/platform_display.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/platform_display.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/platform_display_delegate.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/test_utils.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/test_utils.h
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/window_server.cc
[modify] https://crrev.com/05ee8278913d7012f5216505e243d1b5b2728ba6/services/ui/ws/window_server.h

Comment 3 by sadrul@chromium.org, Jul 15 2016

Blocking: 557401

Comment 4 by sadrul@chromium.org, Jul 25 2016

Status: Fixed (was: Started)
sadrul@- can you let us know a way to verify this defect.How to enable mus and verify the high contrast mode on mus??
The landed code is not yet testable without making additional changes in the code, unfortunately.
Status: Verified (was: Fixed)
Given #6, we'll mark this as Verified and catch it with  issue 557401  instead
Status: Assigned (was: Verified)
Reopening because it was removed due to a layering violation.
Labels: NewComponent-Accessibility-Features
Labels: NewComponent-Accessibility
Labels: Type-Feature
Labels: -newcomponent-accessibility -newcomponent-accessibility-features
Components: -MUS Internals>Services>WindowService
Blocking: 594887

Sign in to add a comment