New issue
Advanced search Search tips

Issue 626435 link

Starred by 1 user
Status: Fixed
Owner:
iclell...@chromium.org
Closed: Jul 2016
Cc:
feature-...@grotations.appspotmail.com
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Origin Trials cannot be added to interfaces with no existing instance

Project Member Reported by iclell...@chromium.org, Jul 7 2016 
The current bindings generation code for origin trials creates methods which require an instance object to be passed, from which we get the prototype and interface objects. This is necessary for adding trials to the global object, but not required for adding trials to e.g., navigator, and not possible for adding trials to e.g., HTMLLinkElement.

If no members for a particular origin trial feature are defined as residing OnInstance, then we can generate different code, taking only the ScriptState. We can use the WrapperInfo to get both the interface and prototype objects, and the instance is not needed.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d48d54439b76ce3736de03206f6c0699d497ec6

commit 4d48d54439b76ce3736de03206f6c0699d497ec6
Author: iclelland <iclelland@chromium.org>
Date: Fri Jul 08 19:13:20 2016

[OriginTrials] Allow origin trials to be installed without an instance object.

Many origin trial features can be installed on interfaces and prototype
objects without requiring an existing interface object. This creates an
alternate method signature for installing such features, and simplifies
the bindings installation code.

BUG= 626435 
R=yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2130883002
Cr-Commit-Position: refs/heads/master@{#404455}

[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/bindings/templates/interface.h
[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/bindings/templates/interface_base.cpp
[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/bindings/templates/partial_interface.h
[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h
[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.h
[modify] https://crrev.com/4d48d54439b76ce3736de03206f6c0699d497ec6/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

Comment 2 by iclell...@chromium.org, Jul 12 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b055688290331fde1745712fcf303d2a72711e08

commit b055688290331fde1745712fcf303d2a72711e08
Author: iclelland <iclelland@chromium.org>
Date: Wed Jul 13 15:03:50 2016

Fix use of itertools.groupby when collecting origin trial members

BUG= 626435 
R=yukishiino@chromium.org, mek@chromium.org

Review-Url: https://codereview.chromium.org/2141083002
Cr-Commit-Position: refs/heads/master@{#405151}

[modify] https://crrev.com/b055688290331fde1745712fcf303d2a72711e08/third_party/WebKit/Source/bindings/scripts/v8_interface.py
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b055688290331fde1745712fcf303d2a72711e08

commit b055688290331fde1745712fcf303d2a72711e08
Author: iclelland <iclelland@chromium.org>
Date: Wed Jul 13 15:03:50 2016

Fix use of itertools.groupby when collecting origin trial members

BUG= 626435 
R=yukishiino@chromium.org, mek@chromium.org

Review-Url: https://codereview.chromium.org/2141083002
Cr-Commit-Position: refs/heads/master@{#405151}

[modify] https://crrev.com/b055688290331fde1745712fcf303d2a72711e08/third_party/WebKit/Source/bindings/scripts/v8_interface.py
►

Sign in to add a comment