New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626430 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Write policy_PluginsBlockedForUrls test using EP Framework

Project Member Reported by scunning...@chromium.org, Jul 7 2016

Issue description

Write automated test for policy_PluginsBlockedForUrls using EP Framework. Note that test also should verify DefaultPluginsSetting=1 (allow) and 3 (click to play).

 
Correction: Test need not verify DefaultPluginsSetting=3.
Owner: scunning...@chromium.org
Status: Started (was: Assigned)
CL https://chromium-review.googlesource.com/#/c/387273/
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/11134d8b6f6839bc945a0416b42f2b09797e2d2d

commit 11134d8b6f6839bc945a0416b42f2b09797e2d2d
Author: Scott Cunningham <scunningham@chromium.org>
Date: Wed Sep 21 00:13:41 2016

Add policy_PluginsBlockedForUrls test to telemetry suite.

Also moved shared resources (plugin_status.html and plugin_flash.swf)
to a common directory in cros/policy. This required some changes to
cros/enterprise_policy_base.py class, to allow the webserver to be
(optionally) pointed to a directory other than the test's. Change
is currently backward compatibile with all other existing xxxForUrls
tests, that haven't yet had their shared resources moved to the
common directory.

BUG= chromium:626430 
TEST=test_that <IP> policy_PluginsBlockedForUrls --args='case=SiteNotBlocked_Run'

Change-Id: I45138133fbfae9141ef383152c5facaaa4ae79af
Reviewed-on: https://chromium-review.googlesource.com/387273
Tested-by: Scott Cunningham <scunningham@chromium.org>
Trybot-Ready: Scott Cunningham <scunningham@chromium.org>
Reviewed-by: Scott Cunningham <scunningham@chromium.org>
Commit-Queue: Scott Cunningham <scunningham@chromium.org>

[rename] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/cros/policy/plugin_flash.swf
[add] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/site_tests/policy_PluginsBlockedForUrls/src/Makefile
[add] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/site_tests/policy_PluginsBlockedForUrls/policy_PluginsBlockedForUrls.py
[modify] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/site_tests/policy_PluginsAllowedForUrls/policy_PluginsAllowedForUrls.py
[add] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/site_tests/policy_PluginsBlockedForUrls/control.sitenotblocked_run
[add] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/site_tests/policy_PluginsBlockedForUrls/control.siteblocked_block
[add] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/site_tests/policy_PluginsBlockedForUrls/control
[modify] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/cros/enterprise_policy_base.py
[rename] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/cros/policy/plugin_status.html
[add] https://crrev.com/11134d8b6f6839bc945a0416b42f2b09797e2d2d/client/site_tests/policy_PluginsBlockedForUrls/control.notset_run

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4f624d3ad3ef53b9b23eae89ada3a48de04c22a9

commit 4f624d3ad3ef53b9b23eae89ada3a48de04c22a9
Author: Scott Cunningham <scunningham@chromium.org>
Date: Sat Sep 24 17:32:04 2016

Add latest policy_* tests to telemetry suite.

Includes policy_PluginsBlockedForUrls, and restores
policy_PopupsBlockedForUrls.

BUG= chromium:626430 
TEST=test_that <IP> policy_PluginsBlockedForUrls --args='case=SiteNotBlocked_Run'

Change-Id: I0d8255efc39c725c1a684445de3dd4e6a10bd7e0
Reviewed-on: https://chromium-review.googlesource.com/388763
Tested-by: Scott Cunningham <scunningham@chromium.org>
Trybot-Ready: Scott Cunningham <scunningham@chromium.org>
Reviewed-by: Scott Cunningham <scunningham@chromium.org>
Commit-Queue: Scott Cunningham <scunningham@chromium.org>

[modify] https://crrev.com/4f624d3ad3ef53b9b23eae89ada3a48de04c22a9/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild

Status: Fixed (was: Started)
Owner: ----

Sign in to add a comment