New issue
Advanced search Search tips

Issue 626427 link

Starred by 1 user
Status: Verified
Owner:
tandrii@chromium.org
Closed: Jul 2016
Cc:
rmis...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

CQ Dry run: don't send email on start, but still send email with result success/failure

Project Member Reported by tandrii@chromium.org, Jul 7 2016 
Previously, in  issue 476883  the email audience for CQ Dry Run messages was limited to issue owner and whoever triggered CQ dry run.

How about not sending email at all?

Related work:  issue 596249  where: 
 * I've switched CQ Dry run messages to be autogenerated, meaning they don't show any more by default
 * there is ongoing work to show CQ status url next to commit box, so one has no need to open these messages ever.

Comment 1 by tandrii@chromium.org, Jul 7 2016

Cc: rmis...@chromium.org
rmistry@ as fixer of  issue 476883 , wdyt?

Comment 3 by rmis...@google.com, Jul 7 2016 

Not sure I understand. We will continue to send out normal CQ emails? If yes then why not CQ dry run.
Me (and others I know) upload patchsets with the --dry_run flag and then I wait for emails to see how it did. I do not want to go and keep clicking refresh on an issue.

Comment 4 by tandrii@chromium.org, Jul 7 2016

Summary: CQ Dry run: don't send email on start, but still send email with result success/failure (was: CQ Dry run: don't send emails at all)
Great question! I actually meant to keep the last email, but totally forgot about it actually. So, 1 dry run -> 1 email on completion, unless it's cancelled.

Comment 5 by rmis...@google.com, Jul 7 2016 

1 email on completion SGTM

Comment 6 by tandrii@chromium.org, Jul 8 2016 

Proceeding with this. Refactoring CQ code https://chromereviews.googleplex.com/463267013 to actually tell Rietveld what to do.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 11 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/bedbb409d329ec2ab37573964b725203509db126

commit bedbb409d329ec2ab37573964b725203509db126
Author: tandrii <tandrii@google.com>
Date: Mon Jul 11 13:13:06 2016
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/8970103178cdbca3f2735332a7ca7089d5a221a3

commit 8970103178cdbca3f2735332a7ca7089d5a221a3
Author: tandrii <tandrii@google.com>
Date: Tue Jul 12 13:51:18 2016
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/8970103178cdbca3f2735332a7ca7089d5a221a3

commit 8970103178cdbca3f2735332a7ca7089d5a221a3
Author: tandrii <tandrii@google.com>
Date: Tue Jul 12 13:51:18 2016
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/e5b6e06d57f5a2c1d255560b86494c7b6f839e1a

commit e5b6e06d57f5a2c1d255560b86494c7b6f839e1a
Author: tandrii <tandrii@google.com>
Date: Tue Jul 12 14:56:57 2016
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/14b049efae9b09499b7caf4de1a2982c5bf003a2

commit 14b049efae9b09499b7caf4de1a2982c5bf003a2
Author: tandrii <tandrii@google.com>
Date: Tue Jul 12 15:05:45 2016
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/336dcb7cb65c9db4161ca78958ddaa151fe0a205

commit 336dcb7cb65c9db4161ca78958ddaa151fe0a205
Author: tandrii <tandrii@google.com>
Date: Tue Jul 12 15:41:08 2016
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/06ba5da395943be9dfe46796317f8b7e1db47de6

commit 06ba5da395943be9dfe46796317f8b7e1db47de6
Author: tandrii <tandrii@google.com>
Date: Tue Jul 12 15:43:17 2016
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/e13f93cbf0da21902685011674110a08011eb067

commit e13f93cbf0da21902685011674110a08011eb067
Author: tandrii <tandrii@chromium.org>
Date: Tue Jul 12 15:44:19 2016

Revert of Rietveld: rely on CQ to decide whether to send email. (patchset #2 id:20001 of https://codereview.chromium.org/2137553002/ )

Reason for revert:
has a bug.

Original issue's description:
> Rietveld: rely on CQ to decide whether to send email.
>
> Also cleaned up unused form entry from https://codereview.appspot.com/8693043/.
>
> R=sergiyb@chromium.org
> BUG= 626427 
>
> Committed: https://chromium.googlesource.com/infra/infra/+/b7213fb5c56cb0cb5db79b97259e9a5077819de8

TBR=sergiyb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 626427 

Review-Url: https://codereview.chromium.org/2142993002

[modify] https://crrev.com/e13f93cbf0da21902685011674110a08011eb067/appengine/chromium_rietveld/codereview/models.py
[modify] https://crrev.com/e13f93cbf0da21902685011674110a08011eb067/appengine/chromium_rietveld/codereview/utils.py
[modify] https://crrev.com/e13f93cbf0da21902685011674110a08011eb067/appengine/chromium_rietveld/codereview/views.py
[modify] https://crrev.com/e13f93cbf0da21902685011674110a08011eb067/appengine/chromium_rietveld/tests/test_utils.py
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/be6b9405c4d274716ccf13dd8ca3bdc283e621d6

commit be6b9405c4d274716ccf13dd8ca3bdc283e621d6
Author: tandrii <tandrii@chromium.org>
Date: Tue Jul 12 15:55:24 2016

Rietveld: don't email if CQ unchecked the commit message.

CQ normally would immediately afterwards post a comment with a reason,
so there is no reason to spam the owner twice.

Internal CL http://go/chromerev/467867013.

TBR=rmistry@chromium.org,phajdan.jr@chromium.org
BUG= 626427 

Review-Url: https://codereview.chromium.org/2146523002

[modify] https://crrev.com/be6b9405c4d274716ccf13dd8ca3bdc283e621d6/appengine/chromium_rietveld/codereview/views_chromium.py
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/be6b9405c4d274716ccf13dd8ca3bdc283e621d6

commit be6b9405c4d274716ccf13dd8ca3bdc283e621d6
Author: tandrii <tandrii@chromium.org>
Date: Tue Jul 12 15:55:24 2016

Rietveld: don't email if CQ unchecked the commit message.

CQ normally would immediately afterwards post a comment with a reason,
so there is no reason to spam the owner twice.

Internal CL http://go/chromerev/467867013.

TBR=rmistry@chromium.org,phajdan.jr@chromium.org
BUG= 626427 

Review-Url: https://codereview.chromium.org/2146523002

[modify] https://crrev.com/be6b9405c4d274716ccf13dd8ca3bdc283e621d6/appengine/chromium_rietveld/codereview/views_chromium.py

Comment 18 by tandrii@chromium.org, Jul 12 2016

Status: Started (was: Assigned)
Update: Rietveld also sent emails whenever CQ unchecked a commit box. Now it's no longer sent as well as no email sent when CQ is starting dry run. 

Internal rietveld deployed. Public Rietveld next.

Comment 19 by benhenry@chromium.org, Jul 12 2016

Labels: Pri-2

Comment 21 by tandrii@chromium.org, Jul 12 2016

Status: Verified (was: Started)
Public Rietveld deployed (version b0b719d). Successfully tested with https://codereview.chromium.org/2121293005/
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/c454ca1055de42ef396bfbc6fd7ebe5ff502ee74

commit c454ca1055de42ef396bfbc6fd7ebe5ff502ee74
Author: tandrii <tandrii@chromium.org>
Date: Wed Jul 13 11:23:43 2016

Rietveld: don't show (dry run) after commit box is unchecked.

This is workaround because of the bug in CQ committed yesterday
that sent cq_dry_run=True when unchecking the commit box.

BUG= 626427 

Review-Url: https://codereview.chromium.org/2148743002

[modify] https://crrev.com/c454ca1055de42ef396bfbc6fd7ebe5ff502ee74/appengine/chromium_rietveld/templates/patchset.html
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/3f1142d9eb1c4ae9eb1439a3a80fb34e315a9efa

commit 3f1142d9eb1c4ae9eb1439a3a80fb34e315a9efa
Author: tandrii <tandrii@google.com>
Date: Wed Jul 13 11:54:05 2016
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/bf6e19fbcc4bc68397965743f0b5ceae9be80e04

commit bf6e19fbcc4bc68397965743f0b5ceae9be80e04
Author: tandrii <tandrii@google.com>
Date: Wed Jul 13 12:13:12 2016
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/ffab3a38d907434cb43d8333d3ba14ff80633a8e

commit ffab3a38d907434cb43d8333d3ba14ff80633a8e
Author: tandrii <tandrii@google.com>
Date: Wed Jul 13 15:19:31 2016
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/ffab3a38d907434cb43d8333d3ba14ff80633a8e

commit ffab3a38d907434cb43d8333d3ba14ff80633a8e
Author: tandrii <tandrii@google.com>
Date: Wed Jul 13 15:19:31 2016
►

Sign in to add a comment