New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626423 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

metrics: report breakdown of scheduler tick time to monarch

Project Member Reported by akes...@chromium.org, Jul 7 2016

Issue description

jrbarnette@ you expressed some interest in this.

I don't think it is as critical as our other metrics yet.
 
Labels: -Pri-2 Pri-1
Owner: jrbarnette@chromium.org
Status: Assigned (was: Available)
Specifically, are you suggesting sending 1 metric per stage of the scheduler tick with a field indicating the stage name?
Re 2, yes (probably).

I'm thinking either:
 - A floating point gauge metric with subfield 'scheduler_stage'.
 - A floating point distribution metric with 'schdeuler_stage'.

Each has its own relative merit. Gauge is easier to graph with a simple query, but can be missing a bit of information, especially if the tick time is short relative to the ts_mon flush period. Realistically gauge is probably fine.
I think we want distribution, right? Seems like the perfect fit - we are repeatedly sampling a random variable.
Yes, distribution would be the more pedantically "correct" choice. It does make the queries slightly harder, and means we can't showing all the sub-times and the aggregate time using a single metric.

Comment 6 by autumn@chromium.org, Jul 12 2016

Labels: -current-issue
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f2c9ac9f514b2c56799974c98c896ae03119c34d

commit f2c9ac9f514b2c56799974c98c896ae03119c34d
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Sep 16 22:44:26 2016

autotest: add stats around db cleanup time

Note, this change requires 386284 to be pushed to prod before it can
land.

CQ-DEPEND=CL:386284
BUG= chromium:626423 
TEST=None

Change-Id: Ie78b731a2797574c89f3a0f855ed2f80768395a2
Reviewed-on: https://chromium-review.googlesource.com/386333
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/f2c9ac9f514b2c56799974c98c896ae03119c34d/scheduler/monitor_db_cleanup.py

Status: Fixed (was: Assigned)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment