New issue
Advanced search Search tips

Issue 626421 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

bugdroid shouldn't watch master-with-bazel branch in BoringSSL

Project Member Reported by davidben@chromium.org, Jul 7 2016

Issue description

Hey Infra folks,

bugdroid recently made this comment:
https://bugs.chromium.org/p/boringssl/issues/detail?id=66#c5

We're going to be automatically maintaining a branch, master-with-bazel, to deal with some buildsystem quirks. It looks like bugdroid is currently watching it? Would it be possible to configure it not to?
 
Cc: aga...@chromium.org mmoss@chromium.org
Components: -Infra Infra>Git
Michael or Aaron, can one of you help triage/own this?

Comment 2 by mmoss@chromium.org, Jul 12 2016

Owner: shey...@chromium.org
Status: Assigned (was: Untriaged)
Owner: aga...@chromium.org
Passing to Aaron for re-triage since Sheng left.
Friendly ping. bugdroid is a little spammy right now on BoringSSL changes. I imagine it's just a config change?

Comment 5 by aga...@chromium.org, Sep 21 2016

Status: Started (was: Assigned)
Sorry, I thought this was fixed with the inclusion of "refs/heads/master" as a filter on the boringssl bugdroid config ages ago, but it turns out that's a regex, and refs/heads/master-with-bazel matches the regex too :)

I've filed a pair of CLs to resolve this. A bigger refactoring of bugdroid's ref-matching code would be nice, but I just spent an hour going down that rabbit hole and didn't get anywhere good so I'm doing this the dumb way.
https://chromereviews.googleplex.com/515697013
https://chromium-review.googlesource.com/387669
Thanks!
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/a0f3bb5a315f594286754d178e4c52594debc3b1

commit a0f3bb5a315f594286754d178e4c52594debc3b1
Author: Aaron Gable <agable@chromium.org>
Date: Wed Sep 21 21:46:16 2016

Make bugdroid match full refs, not ref prefixes

BUG= 626421 

Change-Id: I46f99267a2b934a8f43f861a09d8fd8ca9350673
Reviewed-on: https://chromium-review.googlesource.com/387669
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/a0f3bb5a315f594286754d178e4c52594debc3b1/infra/services/bugdroid/gob_helper.py

Comment 8 by aga...@chromium.org, Sep 22 2016

Status: Fixed (was: Started)
Those two CLs have been landed and deployed. This should now be fixed. Can you verify?
Status: Verified (was: Fixed)
Seems to be good now. Thanks!

Sign in to add a comment