bugdroid shouldn't watch master-with-bazel branch in BoringSSL |
||||||
Issue descriptionHey Infra folks, bugdroid recently made this comment: https://bugs.chromium.org/p/boringssl/issues/detail?id=66#c5 We're going to be automatically maintaining a branch, master-with-bazel, to deal with some buildsystem quirks. It looks like bugdroid is currently watching it? Would it be possible to configure it not to?
,
Jul 12 2016
,
Aug 1 2016
Passing to Aaron for re-triage since Sheng left.
,
Sep 21 2016
Friendly ping. bugdroid is a little spammy right now on BoringSSL changes. I imagine it's just a config change?
,
Sep 21 2016
Sorry, I thought this was fixed with the inclusion of "refs/heads/master" as a filter on the boringssl bugdroid config ages ago, but it turns out that's a regex, and refs/heads/master-with-bazel matches the regex too :) I've filed a pair of CLs to resolve this. A bigger refactoring of bugdroid's ref-matching code would be nice, but I just spent an hour going down that rabbit hole and didn't get anywhere good so I'm doing this the dumb way. https://chromereviews.googleplex.com/515697013 https://chromium-review.googlesource.com/387669
,
Sep 21 2016
Thanks!
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/a0f3bb5a315f594286754d178e4c52594debc3b1 commit a0f3bb5a315f594286754d178e4c52594debc3b1 Author: Aaron Gable <agable@chromium.org> Date: Wed Sep 21 21:46:16 2016 Make bugdroid match full refs, not ref prefixes BUG= 626421 Change-Id: I46f99267a2b934a8f43f861a09d8fd8ca9350673 Reviewed-on: https://chromium-review.googlesource.com/387669 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/a0f3bb5a315f594286754d178e4c52594debc3b1/infra/services/bugdroid/gob_helper.py
,
Sep 22 2016
Those two CLs have been landed and deployed. This should now be fixed. Can you verify?
,
Sep 22 2016
Seems to be good now. Thanks! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by benhenry@chromium.org
, Jul 12 2016Components: -Infra Infra>Git