New issue
Advanced search Search tips

Issue 626409 link

Starred by 2 users
Status: Fixed
Owner:
jkarlin@chromium.org
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Merge clang and vim compile flag generator

Project Member Reported by jkarlin@chromium.org, Jul 7 2016 
There is a src/tools/sublime directory that has a script to determine the compile flags for a given file. There is also such a script in src/tools/vim which has been around for some time and is more general (it uses heuristics to guess flags for new sources not yet in the build system) and it works for more files.

Let's have the sublime script wrap to the vim script.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51f4e51682e2241f394ea2c13c6fb2fff039cefb

commit 51f4e51682e2241f394ea2c13c6fb2fff039cefb
Author: jkarlin <jkarlin@chromium.org>
Date: Wed Jul 20 04:22:02 2016

[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations in the ninja files). Rather than fix it, we
should merge with vim's ycm generator which has to do the same thing and has
been in use for quite some time.

BUG= 626409 

Review-Url: https://codereview.chromium.org/2129993002
Cr-Commit-Position: refs/heads/master@{#406480}

[modify] https://crrev.com/51f4e51682e2241f394ea2c13c6fb2fff039cefb/docs/linux_sublime_dev.md
[modify] https://crrev.com/51f4e51682e2241f394ea2c13c6fb2fff039cefb/tools/sublime/ninja_options_script.py

Comment 2 by jkarlin@chromium.org, Jul 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment