New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626395 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 625007



Sign in to add a comment

[Media Router] Remove support for listenForRouteMessages

Project Member Reported by imch...@chromium.org, Jul 7 2016

Issue description

With  crbug.com/625007  we are introducing a new API to listen for messages in M53. It should be safe to remove the support for old API listenForRouteMessages in media_router_bindings.js two releases later in M55.
 

Comment 1 by sko...@chromium.org, Jul 27 2016

Status: Assigned (was: Untriaged)
Labels: -M-55 Hotlist-CodeHealth M-56
Cc: imch...@chromium.org
Owner: mfo...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aceffa24c81d9399b1cf9ddc626227d5a7c6db88

commit aceffa24c81d9399b1cf9ddc626227d5a7c6db88
Author: mfoltz <mfoltz@chromium.org>
Date: Thu Nov 10 01:06:57 2016

[Media Router] Remove obsolete code and bindings.

- Removes listenForRouteMessages handler
- Removes code for non-Promise returning terminateRoute()
- Makes origin mandatory for onSinksReceived
- Cleans up optional arguments for onRoutesUpdated

BUG= 626395 

Review-Url: https://codereview.chromium.org/2485313002
Cr-Commit-Position: refs/heads/master@{#431124}

[modify] https://crrev.com/aceffa24c81d9399b1cf9ddc626227d5a7c6db88/extensions/renderer/resources/media_router_bindings.js

Comment 5 by mfo...@chromium.org, Nov 10 2016

Status: Fixed (was: Started)

Sign in to add a comment