New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626386 link

Starred by 16 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Tab-modal dialogs (print, cast, basic auth) block keyboard shortcuts and tab dragging

Project Member Reported by sdy@chromium.org, Jul 7 2016

Issue description

Version: 54.0.2790.0
OS: Mac (didn't test on others so far)

What steps will reproduce the problem?
(1) Trigger a tab-modal dialog (e.g. print, cast).
(2) Try to switch tabs using the keyboard.
(3) Try to move the tab in the tab strip, or drag it out into its own window.
(4) Try to switch tabs using the mouse.

What is the expected output?
Tab switching and dragging work normally.

What do you see instead?
Tab switching works with the mouse but not the keyboard.
The tab can't be dragged.
 

Comment 1 by sdy@chromium.org, Jul 7 2016

Cc: pinkerton@chromium.org shrike@chromium.org
Perhaps related to  Issue 416389 .

Labels: Hotlist-GoodFirstBug
Status: Available (was: Untriaged)
The inconsistency between mouse/keyboard is unfortunate, but not functionality breaking. The modal window should forward some events to the parent window. 

Comment 4 by sdy@chromium.org, Sep 26 2016

Labels: Hotlist-MacQualityOfLife

Comment 5 by sdy@chromium.org, Oct 5 2016

Labels: -Hotlist-MacQualityOfLife Proj-MacQualityOfLife
Issue 627163 has been merged into this issue.
Cc: spqc...@chromium.org dvh@chromium.org tapted@chromium.org smokana@chromium.org sail@chromium.org
 Issue 254733  has been merged into this issue.
Cc: -dvh@chromium.org -sail@chromium.org

Comment 9 by sdy@chromium.org, Dec 1 2016

Labels: -Proj-MacQualityOfLife Hotlist-MacQualityOfLife
Labels: -Hotlist-MacQualityOfLife Hotlist-PlatformExcellence
Migrating to more generic platform label, so that it can be applied to other platforms (i.e. I love the idea).
Labels: -Hotlist-GoodFirstBug
This is probably not a good first bug. A lot is changing around this over the next few weeks.

There are two parts:
(2) Try to switch tabs using the keyboard.
(3) Try to move the tab in the tab strip, or drag it out into its own window.

(2) "Should" work with chrome://flags/#secondary-ui-md flipped. This is since a fix for  Issue 603881  for bubbles (both Cocoa and MacViews) -> r447864. But it's incomplete for non-bubbles:

Menu key dispatch breaks (non-menu tab switching like Cmd+Shift+'{' still works) sometimes for tab-modal dialogs with that flag flipped. That's  Issue 605374  that I need to fix soon.

The general issue here for both Cocoa and MacViews is that there's an "overlay" window for tab modals (not bubbles) - the dialog is parented to the overlay window, not the browser, in both cases.


(3) Is orthogonal. We intentionally disable dragging of tabs with modal dialogs open. The management/reparenting of the windows while tab dragging will make the fix very complex. And some dialogs like the certificate viewer are a native Cocoa "sheet" (parented to the overlay window). It's not possible to hide or reparent a Cocoa "sheet" (but we can reparent the overlay window). Anyway, this adds more complexity, and it is very hard to test.

Comment 12 by sdy@chromium.org, Jun 13 2017

Cc: sureshkumari@chromium.org a...@chromium.org ligim...@chromium.org
 Issue 726348  has been merged into this issue.

Comment 13 by sdy@chromium.org, Jun 13 2017

Cc: -pinkerton@chromium.org -shrike@chromium.org
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 14 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Target-70 Proj-MacViews M-70 MacViews-Browser
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
Mac triage: sdy@, can you see to what extent this is still live with macviews?
Labels: -M-70
Labels: M-70
Labels: Group-Focus_Input_Selection_Activation_KeyState
Cc: ew...@chromium.org rpop@chromium.org cl...@chromium.org shrike@chromium.org hwi@chromium.org
 Issue 654621  has been merged into this issue.

Sign in to add a comment