New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626383 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 2
Type: Bug

Blocking:
issue 626442



Sign in to add a comment

Implement Credit Card Sign-in promo for Android and iOS

Project Member Reported by ma...@chromium.org, Jul 7 2016

Issue description

The logic for the Credit Card signin promo is in C++, and will need bridges into the Android Java code [1] and iOS code.

[1] Start the sign in activity on Android from https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java?rcl=0&l=54
 

Comment 1 by ma...@chromium.org, Jul 7 2016

Blocking: 626442

Comment 2 by ma...@chromium.org, Jul 7 2016

Labels: M-54
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a

commit 664a4cfcc194ee6b0f20069db9bfd116cfe5b32a
Author: mathp <mathp@chromium.org>
Date: Tue Jul 19 22:07:07 2016

[Autofill] Add support for signin promo on Android

Will open the AccountSigninActivity.

BUG= 626383 
TEST=manual

Review-Url: https://codereview.chromium.org/2138643004
Cr-Commit-Position: refs/heads/master@{#406394}

[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java
[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java
[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/android/chrome_jni_registrar.cc
[add] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/android/signin/signin_promo_util_android.cc
[add] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/android/signin/signin_promo_util_android.h
[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/signin/signin_promo.cc
[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/signin/signin_promo.h
[add] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/signin/signin_promo_util.cc
[add] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/signin/signin_promo_util.h
[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/ui/sync/sync_promo_ui.cc
[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/browser/ui/webui/app_launcher_login_handler.cc
[modify] https://crrev.com/664a4cfcc194ee6b0f20069db9bfd116cfe5b32a/chrome/chrome_browser.gypi

Comment 4 by ma...@chromium.org, Jul 21 2016

Cc: hwi@chromium.org zkoch@chromium.org
For iOS, here's the current chip system. What should the UI be for the signin promo?
Screen Shot 2016-07-21 at 10.58.47 AM.png
103 KB View Download

Comment 5 by zkoch@chromium.org, Jul 21 2016

Cc: ew...@chromium.org
Hm, the current proposed string is too long to fit into a chip. I think we have two options: 1. ignore iOS for now 2. shorten the string to something that just says, "Sign in to Chrome" or similar. But I don't know how to get the value add in there

Hwi, what's your take?

Comment 6 by hwi@chromium.org, Jul 21 2016

I prefer option 1 (c#5) both for iOS and Clank. The current sign-in promo proposal was suited for Desktop.

Comment 7 by ma...@chromium.org, Jul 21 2016

But Android has the Autofill dropdown, and the platform is the highest order of priority in the PRD: https://docs.google.com/document/d/1NuuMn6Z7hxR2wHWMTiovL-K592nlclsLTjYaYODloeQ/edit

What should we do?

Comment 8 by zkoch@chromium.org, Jul 21 2016

Leave out iOS for now.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0f7ccc063123d306b5cc5f8c48fccff3547c83a

commit f0f7ccc063123d306b5cc5f8c48fccff3547c83a
Author: mathp <mathp@chromium.org>
Date: Thu Jul 21 18:04:01 2016

[Autofill] Remove ifdef for iOS

iOS Autofill uses the different AutofillClientIOS

BUG= 626383 

Review-Url: https://codereview.chromium.org/2167233002
Cr-Commit-Position: refs/heads/master@{#406899}

[modify] https://crrev.com/f0f7ccc063123d306b5cc5f8c48fccff3547c83a/chrome/browser/ui/autofill/chrome_autofill_client.cc

Comment 10 by ma...@chromium.org, Jul 21 2016

Status: Fixed (was: Assigned)
OK, work has completed for now on the Android promo and the non-existent iOS promo.

Sign in to add a comment