powerd should unconditionally turn off keyboard backlight when lid is closed |
||
Issue descriptionI just noticed while looking at some logs that powerd doesn't seem to turn the keyboard backlight off when the lid is closed. It doesn't matter if we suspend (since we'll turn the backlight off for that), but it probably costs a bit of battery in docked mode. (Although for all I know, some hardware may turn it off automatically.)
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3888382f0bbdcbfa8fcbecfd0374a11b058d9f7f commit 3888382f0bbdcbfa8fcbecfd0374a11b058d9f7f Author: Daniel Erat <derat@chromium.org> Date: Thu Jul 07 16:55:48 2016 power: Fix a typo in a comment. BUG= chromium:626378 TEST=none Change-Id: Ib51a970564a06610af0cb3e59fb111e5ea05b959 Reviewed-on: https://chromium-review.googlesource.com/358830 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/3888382f0bbdcbfa8fcbecfd0374a11b058d9f7f/power_manager/powerd/policy/keyboard_backlight_controller.cc
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/ce068c5d283319d546a0ba3c67b286098e3015e0 commit ce068c5d283319d546a0ba3c67b286098e3015e0 Author: Daniel Erat <derat@chromium.org> Date: Thu Jul 07 16:55:48 2016 power: Fix a typo in a comment. BUG= chromium:626378 TEST=none Change-Id: I649d0f580ea7a5ab7762a2260c5066fe80ab4d09 Old-Change-Id: Ib51a970564a06610af0cb3e59fb111e5ea05b959 Reviewed-on: https://chromium-review.googlesource.com/358830 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/381318 Reviewed-by: Wei-Ning Huang <wnhuang@chromium.org> Commit-Queue: Wei-Ning Huang <wnhuang@chromium.org> Tested-by: Wei-Ning Huang <wnhuang@chromium.org> [modify] https://crrev.com/ce068c5d283319d546a0ba3c67b286098e3015e0/power_manager/powerd/policy/keyboard_backlight_controller.cc |
||
►
Sign in to add a comment |
||
Comment 1 by derat@chromium.org
, Jul 7 2016I take that back; I misread the logs. And here's the current code: bool KeyboardBacklightController::UpdateState(TransitionStyle transition, BrightnessChangeCause cause) { // Force the display off immediately in several special cases. if (shutting_down_ || docked_ || suspended_) return ApplyBrightnessPercent(0.0, transition, cause); (That's a typo, though. Should be "Force the backlight off".)