Finding the right buildbot link that shows unittests stderr is too hard and time consuming |
|||||
Issue descriptionI ran some tryjobs on https://codereview.chromium.org/2043913006/ win_chromium_rel_ng seems to be red on components_unittests:ProtoUtilsTest.Serialization, which is really fair because I am adding that test there. I'd now like to see the stderr of the test execution. Here comes the hard part. There are more than ten links that look all good candidates to me in the buildbot page (See attachment), none of them gives me the stdout/stderr of the test execution. In details: - [trigger] components_unittests (without patch) has a "stdio" "[stdout]" and "shard #0". None of them seem interesting. - components_unittests (without patch) on Windows-7-SP1 has a "stdio" "[stdout]" and "shard #0 isolated out" None of them are interesting. - components_unittests (retry summary) has a "stdio" and "[stdout]". They only tell me that the test has failed (good) but not why (bad). - Failure reason has a "stdio" "[stdout]" "reason" "[logdog]" I feel all these links are trolling me. Edit: after writing this bug I realized that some of those links are "without patch", ok my fault here I should have read them more carefully. but it's very confusing for them to be right above the red error step. Also turns out that the thing I was really looking for is the "stdio" link of step 152 which is waaaaaaaaay before them, in the middle of the 300 steps. Result: I spent more time trying to find the right stderr link than writing the code for the last patchset. I think the way that buildbot page shows error should be more developer friendly. Most of those links point to some JSON blobs that seem to repeat the same (not so useful) information in a different encoding (JSON, text formatted, with logdog UI).
,
Jul 8 2016
What patchset and builder was this? We have a few ideas around this but I want to make sure it will address this particular problem.
,
Sep 1 2016
,
Mar 4 2017
,
Mar 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6 commit c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6 Author: Dan Jacques <dnj@chromium.org> Date: Sat Mar 04 01:42:16 2017 Only render LogDog links for LogDog-only mode. BuildBot "build.html" templates are updated with specific logic: - If the master has been restarted to pick up "propertymap" export, and - The build has a "log_location" that begins with "logdog://", and - A given step's log has a link with an alias, and - That step isn't the overall build "stdio" (steps / stdio), then ... don't render the useless logdog-only links, since they just contain I/O keepalives. Instead, render the LogDog links directly. This augments BuildBot to export properties as a dictionary so they are usable in a template. This will require a master restart to take effect. This also removes the old "[cache]" links, since they are non-functional and LogDog is preferred. BUG= chromium:626355 TEST=local - Ran a local master and build, observed that things work. Change-Id: Ie9e2917a567b5579a67cd73946f37f0a23d4cf5a Reviewed-on: https://chromium-review.googlesource.com/450019 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6/masters/master.chromium.perf.fyi/templates/build.html [modify] https://crrev.com/c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6/third_party/buildbot_8_4p1/buildbot/status/web/templates/build.html [modify] https://crrev.com/c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6/masters/master.chromium/templates/build.html [modify] https://crrev.com/c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6/masters/master.tryserver.chromium.perf/templates/build.html [modify] https://crrev.com/c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6/masters/master.tryserver.blink/templates/build.html [modify] https://crrev.com/c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6/third_party/buildbot_8_4p1/buildbot/status/web/build.py [modify] https://crrev.com/c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6/masters/master.chromiumos/templates/build.html [modify] https://crrev.com/c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6/masters/master.tryserver.chromium.linux/templates/build.html
,
Mar 4 2017
Builds with only LogDog logs now only show those logs. Builders with both log options will continue to show both, and will switch to LogDog-only when BuildBot logging is disabled for them.
,
Mar 8 2017
This is awesome, btw. Great to see logdog is first class on buildbot now!
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/08163b779db0ebf18f16aa197951febaa9233a59 commit 08163b779db0ebf18f16aa197951febaa9233a59 Author: Dan Jacques <dnj@chromium.org> Date: Fri Mar 24 18:14:08 2017 Apply LogDog-only rendering to all views. Currently, LogDog-only rendering is implemented only for the "build" view. This makes clicks on the waterfall and console dysfunctional, since they will link to the useless LogDog-only notice messages instead of the real logs. Rather than painfully updating every site and template, this introduces a generic projection function that transforms a BuildStep's log and URL entries into LogDog-only compatible entries when appropriate. All applicable build status sites have been updated to use the transformation funciton. This is not expected to introduce any rendering performance degradation, since all of the functions that it uses are already called as part of rendering. This supercedes the functionality introduced in: https://chromium-review.googlesource.com/450019 That CL can be safely reverted after this one lands. BUG= chromium:626355 TEST=local - Visited all views w/ a local BuildBot instance, verified that everything seems to be in order. Change-Id: Ib93b713d3d7f115fbd94d8ae7749e9faedd1afbc Reviewed-on: https://chromium-review.googlesource.com/459123 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/08163b779db0ebf18f16aa197951febaa9233a59/third_party/buildbot_8_4p1/buildbot/status/web/base.py [modify] https://crrev.com/08163b779db0ebf18f16aa197951febaa9233a59/third_party/buildbot_8_4p1/buildbot/status/web/console.py [modify] https://crrev.com/08163b779db0ebf18f16aa197951febaa9233a59/third_party/buildbot_8_4p1/buildbot/status/web/build.py [modify] https://crrev.com/08163b779db0ebf18f16aa197951febaa9233a59/third_party/buildbot_8_4p1/buildbot/status/web/waterfall.py [modify] https://crrev.com/08163b779db0ebf18f16aa197951febaa9233a59/third_party/buildbot_8_4p1/buildbot/status/web/step.py
,
Mar 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/59fd55dcd811e67c55f400af82a751e9f0f519be commit 59fd55dcd811e67c55f400af82a751e9f0f519be Author: Dan Jacques <dnj@google.com> Date: Fri Mar 24 18:17:15 2017
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/009885c1ae7ed64984379bd4483e220bbbaa8bd8 commit 009885c1ae7ed64984379bd4483e220bbbaa8bd8 Author: Daniel Jacques <dnj@chromium.org> Date: Fri Mar 24 18:27:21 2017 Revert "Apply LogDog-only rendering to all views." This reverts commit 08163b779db0ebf18f16aa197951febaa9233a59. Reason for revert: Missed an import. Original change's description: > Apply LogDog-only rendering to all views. > > Currently, LogDog-only rendering is implemented only for the "build" > view. This makes clicks on the waterfall and console dysfunctional, > since they will link to the useless LogDog-only notice messages instead > of the real logs. > > Rather than painfully updating every site and template, this introduces > a generic projection function that transforms a BuildStep's log and URL > entries into LogDog-only compatible entries when appropriate. All > applicable build status sites have been updated to use the > transformation funciton. > > This is not expected to introduce any rendering performance degradation, > since all of the functions that it uses are already called as part of > rendering. > > This supercedes the functionality introduced in: > https://chromium-review.googlesource.com/450019 > > That CL can be safely reverted after this one lands. > > BUG= chromium:626355 > TEST=local > - Visited all views w/ a local BuildBot instance, verified that > everything seems to be in order. > > Change-Id: Ib93b713d3d7f115fbd94d8ae7749e9faedd1afbc > Reviewed-on: https://chromium-review.googlesource.com/459123 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Ryan Tseng <hinoka@chromium.org> > TBR=iannucci@chromium.org,hinoka@chromium.org,dnj@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:626355 Change-Id: I7476c33360dc7f2326a437f290c26b34d9cf9b25 Reviewed-on: https://chromium-review.googlesource.com/459080 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/009885c1ae7ed64984379bd4483e220bbbaa8bd8/third_party/buildbot_8_4p1/buildbot/status/web/base.py [modify] https://crrev.com/009885c1ae7ed64984379bd4483e220bbbaa8bd8/third_party/buildbot_8_4p1/buildbot/status/web/console.py [modify] https://crrev.com/009885c1ae7ed64984379bd4483e220bbbaa8bd8/third_party/buildbot_8_4p1/buildbot/status/web/build.py [modify] https://crrev.com/009885c1ae7ed64984379bd4483e220bbbaa8bd8/third_party/buildbot_8_4p1/buildbot/status/web/waterfall.py [modify] https://crrev.com/009885c1ae7ed64984379bd4483e220bbbaa8bd8/third_party/buildbot_8_4p1/buildbot/status/web/step.py
,
Mar 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/5c0f1bb27bb8b806a501ec05862f36e70280f087 commit 5c0f1bb27bb8b806a501ec05862f36e70280f087 Author: Dan Jacques <dnj@google.com> Date: Fri Mar 24 18:30:55 2017
,
Mar 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/5c0f1bb27bb8b806a501ec05862f36e70280f087 commit 5c0f1bb27bb8b806a501ec05862f36e70280f087 Author: Dan Jacques <dnj@google.com> Date: Fri Mar 24 18:30:55 2017
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/83e20043dedd1db6977c6aa818e66c1f82ff31e1 commit 83e20043dedd1db6977c6aa818e66c1f82ff31e1 Author: Daniel Jacques <dnj@chromium.org> Date: Tue Mar 28 20:32:44 2017 Revert "Only render LogDog links for LogDog-only mode." This reverts commit c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6. Reason for revert: This has been superseded by: https://chromium-review.googlesource.com/c/459445/ Original change's description: > Only render LogDog links for LogDog-only mode. > > BuildBot "build.html" templates are updated with specific logic: > - If the master has been restarted to pick up "propertymap" export, and > - The build has a "log_location" that begins with "logdog://", and > - A given step's log has a link with an alias, and > - That step isn't the overall build "stdio" (steps / stdio), then > > ... don't render the useless logdog-only links, since they just contain > I/O keepalives. Instead, render the LogDog links directly. > > This augments BuildBot to export properties as a dictionary so they are > usable in a template. This will require a master restart to take effect. > > This also removes the old "[cache]" links, since they are non-functional > and LogDog is preferred. > > BUG= chromium:626355 > TEST=local > - Ran a local master and build, observed that things work. > > Change-Id: Ie9e2917a567b5579a67cd73946f37f0a23d4cf5a > Reviewed-on: https://chromium-review.googlesource.com/450019 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Ryan Tseng <hinoka@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > TBR=hinoka@chromium.org,dpranke@chromium.org,dnj@chromium.org,chromium-reviews@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG= chromium:626355 Change-Id: Icd32adfdfca4f5d506a035dcfacf59b85499f7fc Reviewed-on: https://chromium-review.googlesource.com/461292 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.chromium.perf.fyi/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/third_party/buildbot_8_4p1/buildbot/status/web/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.chromium/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.tryserver.chromium.perf/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.tryserver.blink/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/third_party/buildbot_8_4p1/buildbot/status/web/build.py [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.chromiumos/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.tryserver.chromium.linux/templates/build.html
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/83e20043dedd1db6977c6aa818e66c1f82ff31e1 commit 83e20043dedd1db6977c6aa818e66c1f82ff31e1 Author: Daniel Jacques <dnj@chromium.org> Date: Tue Mar 28 20:32:44 2017 Revert "Only render LogDog links for LogDog-only mode." This reverts commit c8a5cd46d615e1b37854fa2b704913f3cc6f1cc6. Reason for revert: This has been superseded by: https://chromium-review.googlesource.com/c/459445/ Original change's description: > Only render LogDog links for LogDog-only mode. > > BuildBot "build.html" templates are updated with specific logic: > - If the master has been restarted to pick up "propertymap" export, and > - The build has a "log_location" that begins with "logdog://", and > - A given step's log has a link with an alias, and > - That step isn't the overall build "stdio" (steps / stdio), then > > ... don't render the useless logdog-only links, since they just contain > I/O keepalives. Instead, render the LogDog links directly. > > This augments BuildBot to export properties as a dictionary so they are > usable in a template. This will require a master restart to take effect. > > This also removes the old "[cache]" links, since they are non-functional > and LogDog is preferred. > > BUG= chromium:626355 > TEST=local > - Ran a local master and build, observed that things work. > > Change-Id: Ie9e2917a567b5579a67cd73946f37f0a23d4cf5a > Reviewed-on: https://chromium-review.googlesource.com/450019 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Ryan Tseng <hinoka@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > TBR=hinoka@chromium.org,dpranke@chromium.org,dnj@chromium.org,chromium-reviews@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG= chromium:626355 Change-Id: Icd32adfdfca4f5d506a035dcfacf59b85499f7fc Reviewed-on: https://chromium-review.googlesource.com/461292 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.chromium.perf.fyi/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/third_party/buildbot_8_4p1/buildbot/status/web/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.chromium/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.tryserver.chromium.perf/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.tryserver.blink/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/third_party/buildbot_8_4p1/buildbot/status/web/build.py [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.chromiumos/templates/build.html [modify] https://crrev.com/83e20043dedd1db6977c6aa818e66c1f82ff31e1/masters/master.tryserver.chromium.linux/templates/build.html |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by primiano@chromium.org
, Jul 7 201651.4 KB
51.4 KB View Download