New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626351 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 639277
issue 639286
issue 639874



Sign in to add a comment

Split MediaContentType and AudioFocusType from MediaSession::Type

Project Member Reported by zqzh...@chromium.org, Jul 7 2016

Issue description

Since we are planing to handle Pepper (and probably WebRTC) in MediaSession, the existing MediaSession::Type seems won't work well.

Spliting MediaSession::Type into MediaContentType as MediaPlayer attributes, and AudioFocusType for requesting audio focus from the platform.
 
Is this for the internal Media Session code in Chromium or for the API?
Internal Media Session code. Mainly targeting for MediaSession on Desktop :)
Originally I was thinking of moving MediaSession::Type out, but I'm came up with the idea that we need another enum to tell MediaSession which type of player is joining, and the old MediaSession::Type is actually for audio focus (which only have two).
Blocking: 639277
Blocking: 639286
Blocking: 639874
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d8eab739eb23c4fd27ba6a18b0e1afc15182321

commit 5d8eab739eb23c4fd27ba6a18b0e1afc15182321
Author: zqzhang <zqzhang@chromium.org>
Date: Fri Aug 26 20:34:30 2016

Split MediaContentType and AudioFocusType

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

Explainer for this CL:
https://docs.google.com/a/google.com/document/d/1W4uRH8Wvgau0_GtMda4EOSXRtxFuFLhb9W77sJagJpI/edit?usp=sharing

BUG= 626351 

Review-Url: https://codereview.chromium.org/1996043002
Cr-Commit-Position: refs/heads/master@{#414800}

[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/android/browser_media_player_manager.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/android/media_web_contents_observer_android.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/android/media_web_contents_observer_android.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_browsertest.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_controller.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_controller.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_controller_unittest.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_controllers_manager.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_controllers_manager.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_delegate.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_delegate_android.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_delegate_android.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_delegate_android_browsertest.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_delegate_default.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/media_session_delegate_default_browsertest.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/media/session/pepper_playback_observer.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/common/media/media_player_delegate_messages.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/renderer/media/android/webmediaplayer_android.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/renderer/media/renderer_webmediaplayer_delegate.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/renderer/media/renderer_webmediaplayer_delegate.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/content/renderer/media/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/media/base/BUILD.gn
[add] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/media/base/media_content_type.cc
[add] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/media/base/media_content_type.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/media/blink/webmediaplayer_delegate.h
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/5d8eab739eb23c4fd27ba6a18b0e1afc15182321/media/media.gyp

Status: Fixed (was: Started)

Sign in to add a comment