New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626340 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Sync call restrictions should be disabled in single-process mode

Project Member Reported by roc...@chromium.org, Jul 7 2016

Issue description

There will be a lot of sync mojo IPCs from the renderer, but in single-process mode these will be called from a thread in the browser process. With sync calls disabled in the browser, this means renderer sync IPCs need explicit exceptions as well.

We should just disable the restriction in single-process mode.

Alternatively we could also set the property on a per-thread basis (with a process-wide fallback value), but let's start with the simpler solution.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be559ecbba727fb1a78cbff249195cad244375a6

commit be559ecbba727fb1a78cbff249195cad244375a6
Author: rockot <rockot@chromium.org>
Date: Thu Jul 07 19:24:25 2016

Allow mojo sync calls in single-process mode

Lifts the sync call restriction in the browser process
when running in single-process mode.

BUG= 626340 
R=yzshen@chromium.org
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2132573002
Cr-Commit-Position: refs/heads/master@{#404209}

[modify] https://crrev.com/be559ecbba727fb1a78cbff249195cad244375a6/content/browser/browser_main_loop.cc

Comment 2 by roc...@chromium.org, Jul 11 2016

Status: Fixed (was: Assigned)

Sign in to add a comment