New issue
Advanced search Search tips

Issue 626325 link

Starred by 4 users
Status: Verified
Owner:
dtseng@chromium.org
Closed: Jul 2016
Cc:
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All , Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Regression in ChromeVox content script

Project Member Reported by dtseng@chromium.org, Jul 7 2016 
https://codereview.chromium.org/2074513002/

initial_document.js
document.head && document.head.querySelectorAll(...).forEach

forEach is *not* defined on a NodeList.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b13ada6ab99d14d012e77f7a2885c44789c6b08

commit 2b13ada6ab99d14d012e77f7a2885c44789c6b08
Author: dtseng <dtseng@chromium.org>
Date: Fri Jul 15 22:03:35 2016

Avoid the use of foreach on NodeList.

Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because:
- Dartium is behind
- some users don't upgrade Chrome regularly
- failing here causes total silence while within web content

Originally introduced by
crrev.com/2074513002/

BUG= 626325 

TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2127063003
Cr-Commit-Position: refs/heads/master@{#405873}

[modify] https://crrev.com/2b13ada6ab99d14d012e77f7a2885c44789c6b08/chrome/browser/resources/chromeos/chromevox/chromevox/injected/init_document.js

Comment 2 by dtseng@chromium.org, Jul 18 2016

Status: fixed (was: Assigned)

Comment 3 by pbath...@chromium.org, Aug 5 2016

Status: Verified (was: Fixed)
As per #2
►

Sign in to add a comment