ScrollableArea::scrollPositionChanged() updates scrollAnimator with non-clamped position |
||
Issue descriptionCurrently, ScrollableArea updates the scrollAnimator with the argument to scrollPositionChanged(), which may lie outside the min/max scroll position of the area. Instead, it should use the clamped new scroll position obtained from the subclass through scrollPositionDouble().
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f022f5dd7dba6eb56ea8f27ff8636fd33bb0543 commit 3f022f5dd7dba6eb56ea8f27ff8636fd33bb0543 Author: eseckler <eseckler@chromium.org> Date: Tue Jul 12 08:07:20 2016 Clamp in VisualViewport::setScrollPosition. This avoids situations where the viewport's scroll animator may be updated with non-clamped positions by ScrollableArea::setScrollPosition and RootFrameViewport's scrolling may behave incorrectly. BUG=626315 Review-Url: https://codereview.chromium.org/2138823002 Cr-Commit-Position: refs/heads/master@{#404799} [modify] https://crrev.com/3f022f5dd7dba6eb56ea8f27ff8636fd33bb0543/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/3f022f5dd7dba6eb56ea8f27ff8636fd33bb0543/third_party/WebKit/Source/core/frame/VisualViewport.h
,
Nov 23 2017
This is still relevant, though the method name has since changed to ScrollableArea::ScrollOffsetChanged(). This would likely need to be fixed when we enable Blink to keep fractional scroll offsets so blocking that bug here. |
||
►
Sign in to add a comment |
||
Comment 1 by eseckler@chromium.org
, Jul 11 2016Owner: bokan@chromium.org
Status: Assigned (was: Started)