New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 626307 link

Starred by 3 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Jul 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Ink drop Hover for focus state on zoom bubble disappears on hitting tab key

Project Member Reported by sc00335...@techmahindra.com, Jul 7 2016 
Version: 53.0.2785.8 dev 
OS: Ubuntu 14.04,windows

What steps will reproduce the problem?
(1)  Launch chrome and open any page >> Hit F6 so that omnibox gets highlighted >> Now zoom in/Zoom out so that zoom bubble appears >> Immediately hit tab key from keyboard before reset to default button disappears
(2) Now observe focus on zoom bubble

Expected: Focus should remain on zoom bubble so that we can tell where the current focus is.
Actual: Instead Ink drop hover disappears on hitting tab.

NOTE:1. After disappearing if we hover with mouse on it that ink drop hover remains.

2. In general zoom scenario if we hover on bubble and on removing mouse from bubble focus also goes away.

This is a regression issue broken in M53.

Good Build: 53.0.2748.0 dev
Bad Build: 53.0.2750.0 dev

CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/6b4fb0f9025c4cf34374afd19a1a18da058c2796..6f7075c5e44eeb1f99f514e6e8bf53f844f41aa9

Suspecting https://codereview.chromium.org/2001843002 from changelog

@estade: Please confirm the behaviour
Actual_zoombubble.ogv
759 KB View Download
Expected_zoombubble.ogv
937 KB View Download

Comment 1 by ajha@chromium.org, Jul 7 2016 

Couldn't reproduce this on Mac OS 10.11.5 as pressing Cmd+L(F6 doesn't focus the omnibox on Mac) to focus the omnibox and hitting TAB doesn't focus the zoom bubble at any point of time on Mac.

This behavior is seen on Windows-7, latest canary(54.0.2790.0) though.
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 7 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by est...@chromium.org, Jul 7 2016

Labels: -Pri-1 OS-Chrome Pri-2
very much like  bug 623957
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efad9e3a50b9ce33582780a860519e40539c3cef

commit efad9e3a50b9ce33582780a860519e40539c3cef
Author: estade <estade@chromium.org>
Date: Tue Jul 26 17:46:48 2016

Restore focus-state ink drop highlight on buttons after ripple animation
finishes.

At first I just copied the way we restore highlight due to hover (i.e.
I triggered StartHighlightAfterRippleTimer() based on ShouldHighlight(),
not is_hovered_), but that looked sluggish and broken in comparison to just
snapping back to the hover state.

BUG= 626307 , 623957 

Review-Url: https://codereview.chromium.org/2125223004
Cr-Commit-Position: refs/heads/master@{#407845}

[modify] https://crrev.com/efad9e3a50b9ce33582780a860519e40539c3cef/ui/views/animation/ink_drop_impl.cc
[modify] https://crrev.com/efad9e3a50b9ce33582780a860519e40539c3cef/ui/views/animation/ink_drop_impl.h
[modify] https://crrev.com/efad9e3a50b9ce33582780a860519e40539c3cef/ui/views/animation/ink_drop_impl_unittest.cc

Comment 5 by est...@chromium.org, Jul 28 2016

Status: Fixed (was: Assigned)
should be fixed
►

Sign in to add a comment