New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626278 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Digits appear chopped at the bottom in "kissanime" extension

Reported by adha...@etouch.net, Jul 7 2016

Issue description

Chrome Version:53.0.2785.8 (Official Build) c6d43518027ef223fe101efd8baa5a9b1bc979b4-refs/branch-heads/2785@{#37}(32/64-bit)
OS:Windows (7, 8, 10), Mac (10.10.5)(10.11.4),Linux (ubuntu 14.04 LTS)

Test url:https://chrome.google.com/webstore/detail/kissanime/bknmiojpmbccfdeiabecfdiijcgigkfp/related?hl=en

What steps will reproduce the problem?
(1)Launch chrome and navigate to the above URL.
(2)Click on "Add to chrome" to apply extension and click on the extension icon near bookmark bar.
(3)observe the digits next to "Skip for" and "next episode" options.

Actual:Digits appear chopped at the bottom.

Expected:Digits should appear properly.

This is a Regression issue broken in M-53,below is the Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/1a028fbffb2a321037ff2213b03418447998756d..4a06ab9ea2f882871c2f9d678513a1ce990ec8d4?pretty=fuller&n=100

Suspecting:r402210?

Good build:53.0.2781.0
Bad build:53.0.2782.0

Kindly help to re-assign if your change is not the cause for this issue.
 
Actual result.mp4
503 KB View Download
Expected result.mp4
274 KB View Download
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression, please remove if not required.
Thank You.
Cc: cbiesin...@chromium.org
Components: Blink>Layout
Owner: glebl@chromium.org
This is actually a <select>, which means this is likely glebl's change: https://chromium.googlesource.com/chromium/src/+/c2a23354aee0beef71541680def441d025dc37b9

Comment 3 by glebl@chromium.org, Jul 8 2016

Cc: glebl@chromium.org kavvaru@chromium.org durga.behera@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 626551  has been merged into this issue.

Comment 4 by glebl@chromium.org, Jul 11 2016

 Issue 627043  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6

commit c35147b9b40980dcaa3fbe64aa355d461a7e6bd6
Author: glebl <glebl@chromium.org>
Date: Wed Jul 13 07:13:39 2016

Do not use the fixed height for HTML select element if appearance is none.

This patch fixes the problem when a text appears chopped in HTML select element with -webkit-appearance:none. If appearance:none then we should use the height that is calculated based using platform-native styling based on the users' operating system's theme.

R=eae@chromium.org
BUG= 626278 
TEST=third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html

Review-Url: https://codereview.chromium.org/2131303003
Cr-Commit-Position: refs/heads/master@{#405066}

[modify] https://crrev.com/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6/third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html
[modify] https://crrev.com/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a4f5f02db9c1c10b09e76454fe520954df4a425

commit 0a4f5f02db9c1c10b09e76454fe520954df4a425
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Jul 13 09:04:56 2016

Auto-rebaseline for r405066

https://chromium.googlesource.com/chromium/src/+/c35147b9b

BUG= 626278 
TBR=glebl@chromium.org

Review URL: https://codereview.chromium.org/2149433003 .

Cr-Commit-Position: refs/heads/master@{#405100}

[modify] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/menulist-appearance-none-expected.txt
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/menulist-appearance-none-expected.txt
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/select/menulist-appearance-none-expected.txt
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-none-expected.txt
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/win/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/win/fast/forms/select/menulist-appearance-none-expected.txt

Comment 7 by glebl@chromium.org, Jul 13 2016

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6

commit c35147b9b40980dcaa3fbe64aa355d461a7e6bd6
Author: glebl <glebl@chromium.org>
Date: Wed Jul 13 07:13:39 2016

Do not use the fixed height for HTML select element if appearance is none.

This patch fixes the problem when a text appears chopped in HTML select element with -webkit-appearance:none. If appearance:none then we should use the height that is calculated based using platform-native styling based on the users' operating system's theme.

R=eae@chromium.org
BUG= 626278 
TEST=third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html

Review-Url: https://codereview.chromium.org/2131303003
Cr-Commit-Position: refs/heads/master@{#405066}

[modify] https://crrev.com/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6/third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html
[modify] https://crrev.com/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a4f5f02db9c1c10b09e76454fe520954df4a425

commit 0a4f5f02db9c1c10b09e76454fe520954df4a425
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Jul 13 09:04:56 2016

Auto-rebaseline for r405066

https://chromium.googlesource.com/chromium/src/+/c35147b9b

BUG= 626278 
TBR=glebl@chromium.org

Review URL: https://codereview.chromium.org/2149433003 .

Cr-Commit-Position: refs/heads/master@{#405100}

[modify] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/menulist-appearance-none-expected.txt
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/menulist-appearance-none-expected.txt
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/select/menulist-appearance-none-expected.txt
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-none-expected.txt
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/win/fast/forms/select/menulist-appearance-none-expected.png
[add] https://crrev.com/0a4f5f02db9c1c10b09e76454fe520954df4a425/third_party/WebKit/LayoutTests/platform/win/fast/forms/select/menulist-appearance-none-expected.txt

Comment 10 by adha...@etouch.net, Jul 20 2016

Retested the above issue on latest canary chrome version 54.0.2802.0 (Official Build)it seems to be fixed and working as intended.

Kindly find the video below also using latest canary.
Actual result video.mp4
472 KB View Download

Sign in to add a comment