Issue metadata
Sign in to add a comment
|
Regression: Spacing issue observed on ‘chrome://help/'.
Reported by
dmascare...@etouch.net,
Jul 7 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:53.0.2785.8 (Official Build)c6d43518027ef223fe101efd8baa5a9b1bc979b4-refs/branch-heads/2785@{#37} 32/64 bit OS:Windows (7,8,8.1,10), Mac(10.10.5, 10.11.4) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://help/ 2. Observe space between ‘Update Status icon’ and ‘Update Status message’. Actual: More space is seen between ‘Update Status icon’ and ‘Update Status message’. Expected: Spacing should be proper between ‘Update Status icon’ and ‘Update Status message’. This is regression issue, broken in ‘M 53’ and will soon update the bisect info. Good build:53.0.2784.0 Bad build:53.0.2785.0 Note: Issue is not seen on Linux OS.
,
Jul 7 2016
Adding RB Label as this is a recent Regression, please remove if not required. Thank You.
,
Jul 7 2016
Most likely r403319 , which touches help_content.{css,html} update status.
,
Jul 7 2016
This is requested by recent UI review to change the space between the icon and message. elizabethchiu@, could you help clarify?
,
Jul 7 2016
The reason that I made the change is, if you take a look at the screenshot "BEFORE", it looks like a bad mistake when the text clashes with the icon. I'm sure this is not what we are pursuing for. "After" is my proposed spacing treatment for the icon and message. The spacing on the left in "help.png" is too close and the right one is too far off. This is a bit different from what I requested before (I made a comparison), maybe it's because of the different icon or text treatment. The attached is the screenshot comparison of the spacing implemented and what I suggested.
,
Jul 11 2016
,
Jul 12 2016
Consulted with elizabethchiu@, and we will use a smaller icon for eol and adjust the spacing slightly less. The CL is out for review: https://codereview.chromium.org/2142553003/
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8374566fb00b860f8d1d57a594c53d5ad6af3295 commit 8374566fb00b860f8d1d57a594c53d5ad6af3295 Author: xiaoyinh <xiaoyinh@chromium.org> Date: Wed Jul 13 05:14:55 2016 Adjust the spacing between icon and text in about page BUG= 626267 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2142553003 Cr-Commit-Position: refs/heads/master@{#405039} [modify] https://crrev.com/8374566fb00b860f8d1d57a594c53d5ad6af3295/chrome/browser/resources/help/help_content.css [modify] https://crrev.com/8374566fb00b860f8d1d57a594c53d5ad6af3295/ui/webui/resources/images/eol.svg
,
Jul 13 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8374566fb00b860f8d1d57a594c53d5ad6af3295 commit 8374566fb00b860f8d1d57a594c53d5ad6af3295 Author: xiaoyinh <xiaoyinh@chromium.org> Date: Wed Jul 13 05:14:55 2016 Adjust the spacing between icon and text in about page BUG= 626267 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2142553003 Cr-Commit-Position: refs/heads/master@{#405039} [modify] https://crrev.com/8374566fb00b860f8d1d57a594c53d5ad6af3295/chrome/browser/resources/help/help_content.css [modify] https://crrev.com/8374566fb00b860f8d1d57a594c53d5ad6af3295/ui/webui/resources/images/eol.svg
,
Jul 13 2016
Remove the label. This hasn't been merged.
,
Jul 14 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 15 2016
Don't know why it didn't automatically link this bug. It's merged to 53 at eda41f8555e9cb3045f61a60634b268a0dcd66fe
,
Jul 15 2016
mehmet@, please find the expected UI in comment#11. It's a request from UI review that we make the gap wider in 53.
,
Jul 15 2016
Okay, thanks for your feedback.
,
Jul 15 2016
Please merge your change to M53 branch 2785 ASAP (latest by 4:00 PM PST on Monday, 07/18) in order to make it to M53 dev release next week before Beta promotion.
,
Jul 15 2016
govind@, thanks for the reminder. It's merged to 2785 already at eda41f8555e9cb3045f61a60634b268a0dcd66fe I don't know why this bug didn't automatically update it.
,
Jul 15 2016
OK, removing "Merge-Approved-53" label and applying "merge-merged-2785" label.
,
Jul 19 2016
,
Jul 19 2016
ssamanoori@, please find the expected UI in comment#11. It's a request from UI review that we make the gap wider in 53.
,
Jul 19 2016
Based on the above comments and offline chat with xiaoyinh@ initially there was some extra space now the space is reduced based on the UX request. As I see the original bug report screenshot and verification screenshot(comment#22) the space is reduced.
,
Jul 20 2016
As per comments #23 and #24, marking it as TE-Verified. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmascare...@etouch.net
, Jul 7 2016Labels: hasbisect OS-Mac
Owner: fmalita@chromium.org
Status: Assigned (was: Unconfirmed)
43.8 KB
43.8 KB View Download