New issue
Advanced search Search tips

Issue 626264 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

TouchSelectionControllerImpl tests fail with system DPI set to 125%

Project Member Reported by tmonius...@opera.com, Jul 7 2016

Issue description

OS: Windows

On Windows 7:
(1) Open Control Panel -> Personalization -> Display.
(2) Select 125% DPI setting.
(3) Log out from Windows session.
(4) Log in again.
(5) Run views_unittests.exe.

What is the expected output?
All tests should pass.

What do you see instead?
Folowing tests fail:
TouchSelectionControllerImplTest.DoubleTapInTextfieldWithCursorHandleShouldSelectText
TouchSelectionControllerImplTest.SelectRectCallbackTest
TouchSelectionControllerImplTest.SelectRectInBidiCallbackTest
TouchSelectionControllerImplTest.SelectionInBidiTextfieldTest
TouchSelectionControllerImplTest.SelectionInTextfieldTest

On other Windows versions Control Panel looks a little bit different but it's also possible to change the DPI setting. On many new laptops with high-density screens, 125% is the default setting.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bb7f67eec734651731263d35879d5a93b9e3bad

commit 0bb7f67eec734651731263d35879d5a93b9e3bad
Author: tmoniuszko <tmoniuszko@opera.com>
Date: Fri Jul 15 11:19:18 2016

Fix TouchSelectionControllerImpl tests failing with DPI=125%

Make textfield a bit larger so text fits it when system DPI is set to 125%.

Fixes following tests:
TouchSelectionControllerImplTest.DoubleTapInTextfieldWithCursorHandleShouldSelectText
TouchSelectionControllerImplTest.SelectRectCallbackTest
TouchSelectionControllerImplTest.SelectRectInBidiCallbackTest
TouchSelectionControllerImplTest.SelectionInBidiTextfieldTest
TouchSelectionControllerImplTest.SelectionInTextfieldTest

BUG= 626264 

Review-Url: https://codereview.chromium.org/2120353003
Cr-Commit-Position: refs/heads/master@{#405743}

[modify] https://crrev.com/0bb7f67eec734651731263d35879d5a93b9e3bad/ui/views/touchui/touch_selection_controller_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment