New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626260 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird focus ring is seen on link in chrome:// history page.

Reported by rk...@etouch.net, Jul 7 2016

Issue description

Chrome Version: 54.0.2790.0 Revision 39c812dd971e69397daec3d9ba31136c9d4c845d-refs/heads/master@{#404030}
OS: Windows(7,8,10), linux

Pr-condition: 1. Enable Material Design history flag from chrome://flags.
               2. Create some history by navigating any webpage.

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://history
(2) Press Tab key upto focus reaches to link and observe the focus ring.

Actual: Weird focus ring is seen on link of history page.

Expected: Focus ring should be proper.

This is a regression issue, broken in 'M-54', below is bisect info:

Good Build: 54.0.2789.0
Bad Build: 54.0.2790.0

Narrow Bisect: 
https://chromium.googlesource.com/chromium/src/+log/16cafafa820b6a1deababf63d7c24ce5f5e8ecac..3920fa079d497a524eeca5ff3eb6ef0a8981d3e7?pretty=fuller&n=100

Suspecting: r403847

Note: Issue is not seen on Mac OS.
 
History_screenshot.png
43.7 KB View Download
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression, please remove if not required.
Thank You.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9d391f96b194ec3142279f1cd9755c7470462b0

commit a9d391f96b194ec3142279f1cd9755c7470462b0
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Jul 08 02:28:19 2016

MD History: Fix focus highlight on history item text

In crrev.com/403847, a line was removed from history-item's CSS which
did not appear to have any impact on the page. However, this was
necessary for displaying the focus highlight around the item title
correctly. This CL restores the removed line.

BUG= 626260 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2130163002
Cr-Commit-Position: refs/heads/master@{#404312}

[modify] https://crrev.com/a9d391f96b194ec3142279f1cd9755c7470462b0/chrome/browser/resources/md_history/history_item.html

Status: Fixed (was: Assigned)

Sign in to add a comment