New issue
Advanced search Search tips

Issue 626256 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 625865



Sign in to add a comment

V8 Compile API should emit trace-events

Project Member Reported by u...@chromium.org, Jul 7 2016

Issue description

Currently V8 compile API (e.g. ScriptCompiler::Compile) do not emit trace events and rely on tracing in internal compile functions.

With  Issue 625865 , the internal compile functions will emit trace events in v8.compile category instead of default v8 category.

We need to ensure that top level compile events (events not nested in V8.Execute) still appear in default v8 category so that time is attributed to V8 correctly.
 

Comment 1 by u...@chromium.org, Jul 7 2016

Blocking: 625865
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/72a2e68694716b434a1a78517c537fea411a4c35

commit 72a2e68694716b434a1a78517c537fea411a4c35
Author: ulan <ulan@chromium.org>
Date: Thu Jul 07 10:30:51 2016

Add trace event to V8 compiler API.

BUG= chromium:626256 
LOG=NO

Review-Url: https://codereview.chromium.org/2126193002
Cr-Commit-Position: refs/heads/master@{#37578}

[modify] https://crrev.com/72a2e68694716b434a1a78517c537fea411a4c35/src/api.cc

Comment 3 by u...@chromium.org, Jul 7 2016

Status: Fixed (was: Assigned)

Sign in to add a comment