Update CVC unmask prompt string |
||||||
Issue descriptionA few changes: 0.) Title: Enter the CVC for Visa-1245 1.) Body text: "Once you confirm, your card details will be shared with this site" 2.) Change button from "VERIFY" to "CONFIRM" 3.) For Bling, the string will become: "Enter the CVC. Once you confirm, your card details will be shared with this site." Mocks attached.
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47f009f01f84d5e419c2c23588f62da47b1ad2eb commit 47f009f01f84d5e419c2c23588f62da47b1ad2eb Author: jdonnelly <jdonnelly@chromium.org> Date: Fri Jul 08 15:32:38 2016 Update strings in the credit card unmask dialog. The new design doesn't treat Amex cards or the PaymentRequest case differently, so the code is simplified a bit as well. BUG= 626237 Review-Url: https://codereview.chromium.org/2127293002 Cr-Commit-Position: refs/heads/master@{#404392} [modify] https://crrev.com/47f009f01f84d5e419c2c23588f62da47b1ad2eb/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc [modify] https://crrev.com/47f009f01f84d5e419c2c23588f62da47b1ad2eb/components/autofill_strings.grdp
,
Jul 8 2016
,
Jul 8 2016
Tested on all four platforms, including in PaymentRequest flow.
,
Jul 9 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bf2fcf622696ad18ae16624a74bea078123879c commit 0bf2fcf622696ad18ae16624a74bea078123879c Author: Justin Donnelly <jdonnelly@chromium.org> Date: Mon Jul 11 15:21:02 2016 Update strings in the credit card unmask dialog. The new design doesn't treat Amex cards or the PaymentRequest case differently, so the code is simplified a bit as well. BUG= 626237 Review-Url: https://codereview.chromium.org/2127293002 Cr-Commit-Position: refs/heads/master@{#404392} (cherry picked from commit 47f009f01f84d5e419c2c23588f62da47b1ad2eb) Review URL: https://codereview.chromium.org/2142473002 . Cr-Commit-Position: refs/branch-heads/2785@{#79} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/0bf2fcf622696ad18ae16624a74bea078123879c/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc [modify] https://crrev.com/0bf2fcf622696ad18ae16624a74bea078123879c/components/autofill_strings.grdp
,
Jul 12 2016
Tested the same on mac 10.11.5, win8.1 and Linux 14.04 chrome version 53.0.2785.14 - All changes are effected fine Please find the screenshot
,
Jun 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jdonnelly@chromium.org
, Jul 7 2016