New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626231 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD History]Overflow menu doesn't close when searching

Project Member Reported by lshang@chromium.org, Jul 7 2016

Issue description

What steps will reproduce the problem?
(1) Enable MD History by default
(2) navigate to chrome://history
(3) click a "dot dot dot" overflow menu to open it
(4) click on the search field, and start searching for something

What is the expected output?
The overflow menu closes when I start searching or click on search field.

What do you see instead?
The overflow menu didn't change while I searched, just hang there.



 
overflow-menu-hang-there.png
25.8 KB View Download
Labels: Proj-MaterialDesign-WebUI
Owner: tsergeant@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0686269cb57e496229d19ec3b1c48fb68d2b5884

commit 0686269cb57e496229d19ec3b1c48fb68d2b5884
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Jul 22 03:22:21 2016

MD History: Close the item overflow menu when new results load in

This fixes an issue where it was possible to have the menu open
for a history item which is no longer visible.

BUG= 626231 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2165473002
Cr-Commit-Position: refs/heads/master@{#407017}

[modify] https://crrev.com/0686269cb57e496229d19ec3b1c48fb68d2b5884/chrome/browser/resources/md_history/list_container.js
[modify] https://crrev.com/0686269cb57e496229d19ec3b1c48fb68d2b5884/chrome/test/data/webui/md_history/history_overflow_menu_test.js

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 22 2016

Labels: merge-merged-2804
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0686269cb57e496229d19ec3b1c48fb68d2b5884

commit 0686269cb57e496229d19ec3b1c48fb68d2b5884
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Jul 22 03:22:21 2016

MD History: Close the item overflow menu when new results load in

This fixes an issue where it was possible to have the menu open
for a history item which is no longer visible.

BUG= 626231 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2165473002
Cr-Commit-Position: refs/heads/master@{#407017}

[modify] https://crrev.com/0686269cb57e496229d19ec3b1c48fb68d2b5884/chrome/browser/resources/md_history/list_container.js
[modify] https://crrev.com/0686269cb57e496229d19ec3b1c48fb68d2b5884/chrome/test/data/webui/md_history/history_overflow_menu_test.js

Sign in to add a comment